applied: [PATCH cluster 02/21] pmxcfs: correctly log message when directory can't be created

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

applied cluster patches 1 & 2

On Fri, Aug 28, 2026 at 03:30:11PM +0200, Shannon Sterz wrote:
> `mkdir(2)` returns 0 on success and -1 on error. so the check that -1
> is returned instead of inverting the return value. since errno would
> not be set on success, this either never triggered or acted on stale
> errnos only.
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> 
> Notes:
>     feel free to merge this into the previous commit. mainly sending this
>     to separate changes that affect behavior from those that only affect
>     formatting
> 
>  src/pmxcfs/status.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
> index 4aeeaee..9581e2a 100644
> --- a/src/pmxcfs/status.c
> +++ b/src/pmxcfs/status.c
> @@ -1232,7 +1232,7 @@ static inline const char *rrd_skip_data(const char *data, int count, char separa
>  }
>  
>  static inline void checked_mkdir(char *path, int mode) {
> -    if (!mkdir(path, mode) && errno != EEXIST) {
> +    if (mkdir(path, mode) == -1 && errno != EEXIST) {
>          cfs_message("could not create directory %s: %s", path, strerror(errno));
>      }
>  }
> -- 
> 2.47.3
> 
> 
> 
> 
> 

--