public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] sdn: controller: allow creating bgp controller without route-maps
@ 2026-05-06 10:22 Gabriel Goller
  2026-05-15  9:20 ` Gabriel Goller
  0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2026-05-06 10:22 UTC (permalink / raw)
  To: pve-devel

When creating a bgp controller and not supplying any route-maps you get
an error because we always add the delete property on empty.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 www/manager6/sdn/controllers/BgpEdit.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 055378839fd4..08a21d1ab838 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -77,14 +77,14 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-in',
                 fieldLabel: gettext('incoming Route Map'),
-                deleteEmpty: true,
+                deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
             },
             {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-out',
                 fieldLabel: gettext('outgoing Route Map'),
-                deleteEmpty: true,
+                deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
             },
         ];
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH manager] sdn: controller: allow creating bgp controller without route-maps
  2026-05-06 10:22 [PATCH manager] sdn: controller: allow creating bgp controller without route-maps Gabriel Goller
@ 2026-05-15  9:20 ` Gabriel Goller
  0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Goller @ 2026-05-15  9:20 UTC (permalink / raw)
  To: pve-devel

Superseded-by: https://lore.proxmox.com/pve-devel/20260513153656.407423-1-s.hanreich@proxmox.com/




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-15  9:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 10:22 [PATCH manager] sdn: controller: allow creating bgp controller without route-maps Gabriel Goller
2026-05-15  9:20 ` Gabriel Goller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal