From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 2/2] ui: vCPU flag selector: re-enable sortable columns
Date: Tue, 26 May 2026 07:49:38 +0200 [thread overview]
Message-ID: <g745uimm7nvpgvwomleawpklz2qst4saexjvd6syxv67s2jxa4@vhmlqwx5q6yb> (raw)
In-Reply-To: <20260525131839.1720731-3-t.lamprecht@proxmox.com>
On Mon, May 25, 2026 at 03:15:26PM +0200, Thomas Lamprecht wrote:
> The preceding commit replaced the radio widgets, whose inputs went
> stale in reordered rows, with segmented buttons that re-sync on widget
> attach. As that was the only reason sorting was disabled as a
> stop-gap, we can drop that again.
>
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> ---
> www/manager6/form/VMCPUFlagSelector.js | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index 5972ee678..9cd076166 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -4,9 +4,6 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>
> bufferedRenderer: false,
>
> - // FIXME: stop-gap; sorting caused glitches with the inputs of radio widgets in moved rows.
> - sortableColumns: false,
> -
> mixins: {
> field: 'Ext.form.field.Field',
> },
> --
> 2.47.3
>
Did you intend to make the flags sortable by state? Ext.js does not seem
to enable sorting by default on widgetcolumns (at least the examples in
the docs [0] are also not sortable).
If yes (I think such a sort would be helpful to see which flags are
enabled), we would need to add sortable: true to the "Value" column.
[0] https://docs.sencha.com/extjs/7.0.0/guides/components/widgets_widgets_columns.html
prev parent reply other threads:[~2026-05-26 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 13:15 [PATCH manager 0/2] ui: vCPU flag editor: switch radio group approach to segmented button Thomas Lamprecht
2026-05-25 13:15 ` [PATCH manager 1/2] ui: vCPU flag selector: replace radio group with " Thomas Lamprecht
2026-05-26 6:02 ` Arthur Bied-Charreton
2026-05-25 13:15 ` [PATCH manager 2/2] ui: vCPU flag selector: re-enable sortable columns Thomas Lamprecht
2026-05-26 5:49 ` Arthur Bied-Charreton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g745uimm7nvpgvwomleawpklz2qst4saexjvd6syxv67s2jxa4@vhmlqwx5q6yb \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox