From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E74721FF146 for ; Tue, 26 May 2026 07:49:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F3F9A11FAB; Tue, 26 May 2026 07:49:44 +0200 (CEST) Date: Tue, 26 May 2026 07:49:38 +0200 From: Arthur Bied-Charreton To: Thomas Lamprecht Subject: Re: [PATCH manager 2/2] ui: vCPU flag selector: re-enable sortable columns Message-ID: References: <20260525131839.1720731-1-t.lamprecht@proxmox.com> <20260525131839.1720731-3-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260525131839.1720731-3-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779774555352 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.765 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sencha.com] Message-ID-Hash: VEMFD6MR3RWZENKPIS6NOBO3UCTYEXAO X-Message-ID-Hash: VEMFD6MR3RWZENKPIS6NOBO3UCTYEXAO X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, May 25, 2026 at 03:15:26PM +0200, Thomas Lamprecht wrote: > The preceding commit replaced the radio widgets, whose inputs went > stale in reordered rows, with segmented buttons that re-sync on widget > attach. As that was the only reason sorting was disabled as a > stop-gap, we can drop that again. > > Signed-off-by: Thomas Lamprecht > --- > www/manager6/form/VMCPUFlagSelector.js | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index 5972ee678..9cd076166 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -4,9 +4,6 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > > bufferedRenderer: false, > > - // FIXME: stop-gap; sorting caused glitches with the inputs of radio widgets in moved rows. > - sortableColumns: false, > - > mixins: { > field: 'Ext.form.field.Field', > }, > -- > 2.47.3 > Did you intend to make the flags sortable by state? Ext.js does not seem to enable sorting by default on widgetcolumns (at least the examples in the docs [0] are also not sortable). If yes (I think such a sort would be helpful to see which flags are enabled), we would need to add sortable: true to the "Value" column. [0] https://docs.sencha.com/extjs/7.0.0/guides/components/widgets_widgets_columns.html