From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: "Max R. Carrara" <m.carrara@proxmox.com>
Cc: pve-devel@lists.proxmox.com,
Alfonso Kuen <gerencia@idkmanager.com>,
Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
Jakob Klocker <j.klocker@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH pve-common v4 01/17] json schema: add multiline string format
Date: Tue, 10 Nov 2026 14:39:15 +0100 [thread overview]
Message-ID: <fzwusubo2vpnnx5bpuaqhid4xlviyfxgljtlspcm2o7p2l4pr2@os7yxnuuu7ak> (raw)
In-Reply-To: <20261106154554.2182986-2-m.carrara@proxmox.com>
Given that right now, newlines are almost never wanted/allowed in our
API (apart from comments), there's a case to be made here that we might
just want a multiline schema flag. (Where by default we'd reject
newlines. This could potentially remove a whole class of possible future
section-config related bugs…)
Also, consider that on the rust side, 'format', 'enum', 'pattern', and
the verify-functions are part of the `ApiStringFormat` *enum*, so you
can only have one, and we do not have *named* formats at all.
Thomas also played around with the thought of adding a multiline boolean
to string schemas, so this may be a good time to come to a decision
here.
IMO, while not strictly being part of any JSONSchema/openapi spec, it
would be fine to have that. Also, I'm quite sure that whenever we use
patterns or other formats, a pattern which does not want to opt into
multiline support should be written in a way which does not allow
newlines *anyway*, so for the most part it would act as a hint, but
additionally provide a safe-guard just in case.
On Fri, Nov 06, 2026 at 04:45:37PM +0100, Max R. Carrara wrote:
> Add a new format named "multiline".
>
> This format explicitly signals to other components (e.g. a client)
> that a string is a multiline string and should remain one, without
> folding newlines or replacing them with spaces, for example.
>
> Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> ---
> src/PVE/JSONSchema.pm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
> index 34f2949..5790a32 100644
> --- a/src/PVE/JSONSchema.pm
> +++ b/src/PVE/JSONSchema.pm
> @@ -236,10 +236,15 @@ sub get_renderer {
>
> # register some common type for pve
>
> register_format('string', sub { }); # allow format => 'string-list'
>
> +# A multiline string.
> +# Used to explicitly tell other components that a string should not
> +# have its newlines folded or replaced with spaces.
> +register_format('multiline', sub { });
> +
> register_format('urlencoded', \&pve_verify_urlencoded);
>
> sub pve_verify_urlencoded {
> my ($text, $noerr) = @_;
> if ($text !~ /^[-%a-zA-Z0-9_.!~*'()]*\z/) {
> --
> 2.47.3
next prev parent reply other threads:[~2026-11-10 13:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 15:45 [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v4 00/17] GUI Support for Custom Storage Plugins Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-common v4 01/17] json schema: add multiline string format Max R. Carrara
2026-11-10 13:39 ` Wolfgang Bumiller [this message]
2026-11-06 15:45 ` [PATCH pve-storage v4 02/17] api: plugins/storage: add initial routes and endpoints Max R. Carrara
2026-11-10 14:35 ` Wolfgang Bumiller
2026-11-06 15:45 ` [PATCH pve-storage v4 03/17] api: plugins/storage/plugin: include schema in plugin metadata Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 04/17] api: plugins/storage/plugin: mark sensitive properties in schema Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 05/17] api: plugins/storage/plugin: factor plugin metadata code into helper Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 06/17] api: plugins/storage/plugin: add plugins' 'content' to their metadata Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 07/17] all plugins: add 'title' to properties, adapt 'description's Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 08/17] all plugins, api: mark certain properties as advanced in plugindata() Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 09/17] all plugins, api: mark certain properties as hidden " Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 10/17] form: introduce new 'proxmoxtextarea' field Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 11/17] utils: introduce helper function getFieldDefFromPropertySchema Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 12/17] acme: use helper to construct ExtJS fields from property schemas Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 13/17] api: sort modules and API method registrations Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 14/17] api: add API routes 'plugins' and 'plugins/storage' Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 15/17] ui: storage view: display error when no editor for storage type exists Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 16/17] ui: storage: add basic UI integration for custom storage plugins Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage-plugin-examples v4 17/17] sshfs: Update SSHFS plugin Max R. Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fzwusubo2vpnnx5bpuaqhid4xlviyfxgljtlspcm2o7p2l4pr2@os7yxnuuu7ak \
--to=w.bumiller@proxmox.com \
--cc=gerencia@idkmanager.com \
--cc=j.klocker@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox