public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Alfonso Kuen <gerencia@idkmanager.com>,
	Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
	Jakob Klocker <j.klocker@proxmox.com>
Subject: [PATCH pve-manager v4 13/17] api: sort modules and API method registrations
Date: Fri,  6 Nov 2026 16:45:49 +0100	[thread overview]
Message-ID: <20261106154554.2182986-14-m.carrara@proxmox.com> (raw)
In-Reply-To: <20261106154554.2182986-1-m.carrara@proxmox.com>

... so as to better adhere to our style guide [guide].

Note that this also changes the order of the entries in the API's
root directory index ('GET /'), as it lists the registered
subdirectories in registration order.

[guide] https://pve.proxmox.com/wiki/Perl_Style_Guide#Module_Dependencies

Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
 PVE/API2.pm | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/PVE/API2.pm b/PVE/API2.pm
index 0c7e4654..9f1ec961 100644
--- a/PVE/API2.pm
+++ b/PVE/API2.pm
@@ -1,50 +1,50 @@
 package PVE::API2;
 
 use strict;
 use warnings;
 
-use PVE::pvecfg;
 use PVE::DataCenterConfig;
 use PVE::GuestHelpers;
-use PVE::RESTHandler;
 use PVE::JSONSchema;
+use PVE::RESTHandler;
+use PVE::pvecfg;
 
 use base qw(PVE::RESTHandler);
 
 # preload classes
+use PVE::API2::AccessControl;
 use PVE::API2::Cluster;
 use PVE::API2::Nodes;
 use PVE::API2::Pool;
-use PVE::API2::AccessControl;
 use PVE::API2::Storage::Config;
 
+__PACKAGE__->register_method({
+    subclass => "PVE::API2::AccessControl",
+    path => 'access',
+});
+
 __PACKAGE__->register_method({
     subclass => "PVE::API2::Cluster",
     path => 'cluster',
 });
 
 __PACKAGE__->register_method({
     subclass => "PVE::API2::Nodes",
     path => 'nodes',
 });
 
-__PACKAGE__->register_method({
-    subclass => "PVE::API2::Storage::Config",
-    path => 'storage',
-});
-
-__PACKAGE__->register_method({
-    subclass => "PVE::API2::AccessControl",
-    path => 'access',
-});
-
 __PACKAGE__->register_method({
     subclass => "PVE::API2::Pool",
     path => 'pools',
 });
 
+__PACKAGE__->register_method({
+    subclass => "PVE::API2::Storage::Config",
+    path => 'storage',
+});
+
 __PACKAGE__->register_method({
     name => 'index',
     path => '',
     method => 'GET',
     permissions => { user => 'all' },
-- 
2.47.3





  parent reply	other threads:[~2026-11-06 15:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:45 [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v4 00/17] GUI Support for Custom Storage Plugins Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-common v4 01/17] json schema: add multiline string format Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 02/17] api: plugins/storage: add initial routes and endpoints Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 03/17] api: plugins/storage/plugin: include schema in plugin metadata Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 04/17] api: plugins/storage/plugin: mark sensitive properties in schema Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 05/17] api: plugins/storage/plugin: factor plugin metadata code into helper Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 06/17] api: plugins/storage/plugin: add plugins' 'content' to their metadata Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 07/17] all plugins: add 'title' to properties, adapt 'description's Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 08/17] all plugins, api: mark certain properties as advanced in plugindata() Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage v4 09/17] all plugins, api: mark certain properties as hidden " Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 10/17] form: introduce new 'proxmoxtextarea' field Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 11/17] utils: introduce helper function getFieldDefFromPropertySchema Max R. Carrara
2026-11-06 15:45 ` [PATCH proxmox-widget-toolkit v4 12/17] acme: use helper to construct ExtJS fields from property schemas Max R. Carrara
2026-11-06 15:45 ` Max R. Carrara [this message]
2026-11-06 15:45 ` [PATCH pve-manager v4 14/17] api: add API routes 'plugins' and 'plugins/storage' Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 15/17] ui: storage view: display error when no editor for storage type exists Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-manager v4 16/17] ui: storage: add basic UI integration for custom storage plugins Max R. Carrara
2026-11-06 15:45 ` [PATCH pve-storage-plugin-examples v4 17/17] sshfs: Update SSHFS plugin Max R. Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106154554.2182986-14-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=gerencia@idkmanager.com \
    --cc=j.klocker@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.ellmenreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal