public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf
Date: Wed, 10 Jun 2026 15:43:21 +0200	[thread overview]
Message-ID: <fee8c8fd-c390-4a8a-830d-2384db3b1abc@proxmox.com> (raw)
In-Reply-To: <20260610134117.3100390-1-d.csapak@proxmox.com>

this is actually v3, sorry^^

On 6/10/26 3:41 PM, Dominik Csapak wrote:
> OVMF can only use PXE/network boot when a virtual RNG device is added
> for VMs, but this is not obvious from the UI or the error behavior.
> 
> Add a small warning to the boot order edit that says what is necessary.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> changes from v1:
> * incorporated fionas feedback (thanks!)
> * include r-b trailer from fiona
> 
>   www/manager6/qemu/BootOrderEdit.js | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/www/manager6/qemu/BootOrderEdit.js b/www/manager6/qemu/BootOrderEdit.js
> index 521a3d6e..08e71913 100644
> --- a/www/manager6/qemu/BootOrderEdit.js
> +++ b/www/manager6/qemu/BootOrderEdit.js
> @@ -26,6 +26,7 @@ Ext.define('PVE.qemu.BootOrderPanel', {
>               let grid = me.lookup('grid');
>               let marker = me.lookup('marker');
>               let emptyWarning = me.lookup('emptyWarning');
> +            let rngPxeWarning = me.lookup('rngPxeWarning');
>   
>               marker.originalValue = undefined;
>   
> @@ -43,6 +44,14 @@ Ext.define('PVE.qemu.BootOrderPanel', {
>                           view.inUpdate = false;
>                           marker.checkDirty();
>                           emptyWarning.setHidden(val !== '');
> +
> +                        let showRngPxeWarning =
> +                            view.vmconfig?.bios === 'ovmf' &&
> +                            !view.vmconfig?.rng0 &&
> +                            val?.includes('net');
> +
> +                        rngPxeWarning.setHidden(!showRngPxeWarning);
> +
>                           grid.getView().refresh();
>                       },
>                   },
> @@ -238,6 +247,13 @@ Ext.define('PVE.qemu.BootOrderPanel', {
>               userCls: 'pmx-hint',
>               value: gettext('Warning: No devices selected, the VM will probably not boot!'),
>           },
> +        {
> +            xtype: 'displayfield',
> +            reference: 'rngPxeWarning',
> +            userCls: 'pmx-hint',
> +            hidden: true,
> +            value: gettext('Warning: For PXE boot with OVMF, you must add a VirtIO RNG device!'),
> +        },
>           {
>               // for dirty marking and 'reset' function
>               xtype: 'field',





  reply	other threads:[~2026-06-10 13:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 13:40 [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf Dominik Csapak
2026-06-10 13:43 ` Dominik Csapak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-09 12:11 Dominik Csapak
2026-06-09 14:48 ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fee8c8fd-c390-4a8a-830d-2384db3b1abc@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal