From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 661011FF13A for ; Wed, 10 Jun 2026 15:43:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4263EFC57; Wed, 10 Jun 2026 15:43:25 +0200 (CEST) Message-ID: Date: Wed, 10 Jun 2026 15:43:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf From: Dominik Csapak To: pve-devel@lists.proxmox.com References: <20260610134117.3100390-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20260610134117.3100390-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781098954531 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HQ4UESA5M2BB43GNUSLQ73YH5MDYWO5V X-Message-ID-Hash: HQ4UESA5M2BB43GNUSLQ73YH5MDYWO5V X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this is actually v3, sorry^^ On 6/10/26 3:41 PM, Dominik Csapak wrote: > OVMF can only use PXE/network boot when a virtual RNG device is added > for VMs, but this is not obvious from the UI or the error behavior. > > Add a small warning to the boot order edit that says what is necessary. > > Signed-off-by: Dominik Csapak > Reviewed-by: Fiona Ebner > --- > changes from v1: > * incorporated fionas feedback (thanks!) > * include r-b trailer from fiona > > www/manager6/qemu/BootOrderEdit.js | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/www/manager6/qemu/BootOrderEdit.js b/www/manager6/qemu/BootOrderEdit.js > index 521a3d6e..08e71913 100644 > --- a/www/manager6/qemu/BootOrderEdit.js > +++ b/www/manager6/qemu/BootOrderEdit.js > @@ -26,6 +26,7 @@ Ext.define('PVE.qemu.BootOrderPanel', { > let grid = me.lookup('grid'); > let marker = me.lookup('marker'); > let emptyWarning = me.lookup('emptyWarning'); > + let rngPxeWarning = me.lookup('rngPxeWarning'); > > marker.originalValue = undefined; > > @@ -43,6 +44,14 @@ Ext.define('PVE.qemu.BootOrderPanel', { > view.inUpdate = false; > marker.checkDirty(); > emptyWarning.setHidden(val !== ''); > + > + let showRngPxeWarning = > + view.vmconfig?.bios === 'ovmf' && > + !view.vmconfig?.rng0 && > + val?.includes('net'); > + > + rngPxeWarning.setHidden(!showRngPxeWarning); > + > grid.getView().refresh(); > }, > }, > @@ -238,6 +247,13 @@ Ext.define('PVE.qemu.BootOrderPanel', { > userCls: 'pmx-hint', > value: gettext('Warning: No devices selected, the VM will probably not boot!'), > }, > + { > + xtype: 'displayfield', > + reference: 'rngPxeWarning', > + userCls: 'pmx-hint', > + hidden: true, > + value: gettext('Warning: For PXE boot with OVMF, you must add a VirtIO RNG device!'), > + }, > { > // for dirty marking and 'reset' function > xtype: 'field',