From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v3] fix #7711: pci: try to detect large memory region preconditions
Date: Tue, 7 Jul 2026 13:01:43 +0200 [thread overview]
Message-ID: <ef2a9511-749f-4477-ac7a-aba9dfbd6ade@proxmox.com> (raw)
In-Reply-To: <7c4756d4-f592-474a-8116-cbbf10b9c690@proxmox.com>
Am 07.07.26 um 12:21 PM schrieb Dominik Csapak:
> On 7/7/26 11:11 AM, Fiona Ebner wrote:
>> Am 06.07.26 um 3:10 PM schrieb Dominik Csapak:
>>> + if (($flags & 0x200) != 0) {
>>> + # $end is inclusive, so + 1 for the overall size
>>> + my $size = $end - $start + 1;
>>> + if ($size > $biggest_size) {
>>> + $biggest_size = $size;
>>> + }
>>> + }
>>> + }
>>
>> Should we add an else branch warning about unexpected lines just to be
>> sure?
>
> i'm not convinced we'd gain anything by that. the format of these
> kernel provided sysfs files are rather static, not sure how likely
> it is that this changes
The issue is that there is no additional fallout/failure later, but the
check would just quietly stop working if it does change for whatever
reason (maybe if they add a new entry at the end?).
next prev parent reply other threads:[~2026-07-07 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 13:08 [PATCH qemu-server v3] fix #7711: pci: try to detect large memory region preconditions Dominik Csapak
2026-07-07 9:11 ` Fiona Ebner
2026-07-07 10:21 ` Dominik Csapak
2026-07-07 11:01 ` Fiona Ebner [this message]
2026-07-07 11:06 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef2a9511-749f-4477-ac7a-aba9dfbd6ade@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox