Re: [PATCH qemu-server v3] fix #7711: pci: try to detect large memory region preconditions

[Dominik Csapak <d.csapak@proxmox.com>]

On 7/7/26 1:01 PM, Fiona Ebner wrote:
> Am 07.07.26 um 12:21 PM schrieb Dominik Csapak:
>> On 7/7/26 11:11 AM, Fiona Ebner wrote:
>>> Am 06.07.26 um 3:10 PM schrieb Dominik Csapak:
>>>> +            if (($flags & 0x200) != 0) {
>>>> +                # $end is inclusive, so + 1 for the overall size
>>>> +                my $size = $end - $start + 1;
>>>> +                if ($size > $biggest_size) {
>>>> +                    $biggest_size = $size;
>>>> +                }
>>>> +            }
>>>> +        }
>>>
>>> Should we add an else branch warning about unexpected lines just to be
>>> sure?
>>
>> i'm not convinced we'd gain anything by that. the format of these
>> kernel provided sysfs files are rather static, not sure how likely
>> it is that this changes
> 
> The issue is that there is no additional fallout/failure later, but the
> check would just quietly stop working if it does change for whatever
> reason (maybe if they add a new entry at the end?).

fair, i'll add a short warning