Re: [PATCH guest-common v8 05/22] add module to track previously used guest IDs

[Fiona Ebner <f.ebner@proxmox.com>]

Am 12.10.26 um 5:49 PM schrieb Michael Köppl:
> The /cluster/nextid API endpoint always suggests the lowest free
> guest ID, so IDs of destroyed guests get handed out again. Offering
> an opt-out requires recording every ID that has ever been in use
> somewhere both the endpoint and the guest create and destroy paths
> can reach.
> 
> Store them in /etc/pve/virtual-guest/used-guest-ids and register it as
> a cfs file, so the list is kept in sync cluster-wide. IDs are stored as
> "<start>-<end>" ranges and are not expanded per ID since cfs_read_file()
> hands out a deep copy of the parsed data on every call, which gets
> expensive on clusters that churn through many guests. Adjacent ranges
> are merged on write to keep the file small. Entries that do not parse,
> ranges with reversed bounds included, are skipped with a warning instead
> of failing the whole read.
> 
> get_next_unused_id() returns the lowest ID at or above a given one that
> is neither in use nor recorded as having been used previously.
> 
> Recording failures are non-critical and will only warn while 'unique' is
> off.
> 
> Originally-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
> Originally-by: Severen Redwood <severen.redwood@sitehost.co.nz>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
Consider this one too:
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

Nice work!