[PATCH manager v8 15/22] ui: guest ID selector: show the error returned by nextid

["Michael Köppl" <m.koeppl@proxmox.com>]

The guest ID field validates IDs through the /cluster/nextid endpoint
and reported any failure, including failed requests, as the ID being
in use. Show the error the endpoint returns instead, so that the
actual reason for rejecting an ID is visible. This is also needed for
the endpoint to reject IDs that are not in use, but forbidden by the
next-id datacenter option.

The endpoint's errors are not translated, so keep showing the translated
message that the ID is already in use if the guest is known to the UI.
This leaves the endpoint's error for IDs rejected by next-id enforcement
and for guests the user cannot see.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/form/GuestIDSelector.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/www/manager6/form/GuestIDSelector.js b/www/manager6/form/GuestIDSelector.js
index f3160a744..a7cf421ac 100644
--- a/www/manager6/form/GuestIDSelector.js
+++ b/www/manager6/form/GuestIDSelector.js
@@ -27,7 +27,7 @@ Ext.define('PVE.form.GuestIDSelector', {
         }
 
         if (me.validateExists === false && me.rejected) {
-            return me.inUseID;
+            return me.nextIDError;
         }
 
         return true;
@@ -67,6 +67,15 @@ Ext.define('PVE.form.GuestIDSelector', {
                         },
                         failure: function (response, opts) {
                             me.rejected = true;
+                            // prefer translated message if guest is known to the UI
+                            if (PVE.data.ResourceStore.findVMID(newValue)) {
+                                me.nextIDError = me.inUseID;
+                            } else {
+                                let error = response.result?.errors?.vmid;
+                                me.nextIDError = error
+                                    ? Ext.htmlEncode(error.trim())
+                                    : response.htmlStatus;
+                            }
                             me.validate();
                         },
                     });
-- 
2.47.3