public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Filip Schauer <f.schauer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: applied: [PATCH proxmox] oci: update doc comment of parse_and_extract_image
Date: Thu, 22 Oct 2026 13:22:30 +0200	[thread overview]
Message-ID: <dqcgfujmzgcjv2t7dycsog2ngvvhxoi6ovhtjoxafa6cjtaevq@ba5fevfjge3p> (raw)
In-Reply-To: <20261013082826.27056-1-f.schauer@proxmox.com>

applied, thanks

On Tue, Oct 13, 2026 at 10:28:24AM +0200, Filip Schauer wrote:
> The function does not return the entire image config, only the optional
> execution parameters contained in the image config.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>  proxmox-oci/src/lib.rs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/proxmox-oci/src/lib.rs b/proxmox-oci/src/lib.rs
> index 9ef16d41..b274e46a 100644
> --- a/proxmox-oci/src/lib.rs
> +++ b/proxmox-oci/src/lib.rs
> @@ -101,7 +101,7 @@ pub enum ProxmoxOciError {
>      ExtractError(#[from] ExtractError),
>  }
>  
> -/// Extract the rootfs of an OCI image tar and return the image config.
> +/// Extract the rootfs of an OCI image tar and return its execution parameters.
>  ///
>  /// # Arguments
>  ///
> @@ -109,6 +109,11 @@ pub enum ProxmoxOciError {
>  /// * `rootfs_path` - Destination path where the rootfs will be extracted to
>  /// * `arch` - Optional CPU architecture used to pick the first matching manifest from a multi-arch
>  ///   image index. If `None`, the first manifest will be used.
> +///
> +/// # Returns
> +///
> +/// On success, this returns the optional container execution parameters
> +/// if present in the image configuration.
>  pub fn parse_and_extract_image<P: AsRef<Path>>(
>      oci_tar_path: P,
>      rootfs_path: P,
> -- 
> 2.47.3




      reply	other threads:[~2026-10-22 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  8:28 [PATCH proxmox] oci: update doc comment of parse_and_extract_image Filip Schauer
2026-10-22 11:22 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dqcgfujmzgcjv2t7dycsog2ngvvhxoi6ovhtjoxafa6cjtaevq@ba5fevfjge3p \
    --to=w.bumiller@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal