From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 74AB11FF0EC for ; Thu, 22 Oct 2026 13:22:36 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A3FAC215F8; Thu, 22 Oct 2026 13:22:34 +0200 (CEST) Date: Thu, 22 Oct 2026 13:22:30 +0200 From: Wolfgang Bumiller To: Filip Schauer Subject: applied: [PATCH proxmox] oci: update doc comment of parse_and_extract_image Message-ID: References: <20261013082826.27056-1-f.schauer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261013082826.27056-1-f.schauer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792668150994 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.434 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NKX23HKZQUYPVZSAEIZ7BBEQ4CXH7HMV X-Message-ID-Hash: NKX23HKZQUYPVZSAEIZ7BBEQ4CXH7HMV X-MailFrom: w.bumiller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: applied, thanks On Tue, Oct 13, 2026 at 10:28:24AM +0200, Filip Schauer wrote: > The function does not return the entire image config, only the optional > execution parameters contained in the image config. > > Signed-off-by: Filip Schauer > --- > proxmox-oci/src/lib.rs | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/proxmox-oci/src/lib.rs b/proxmox-oci/src/lib.rs > index 9ef16d41..b274e46a 100644 > --- a/proxmox-oci/src/lib.rs > +++ b/proxmox-oci/src/lib.rs > @@ -101,7 +101,7 @@ pub enum ProxmoxOciError { > ExtractError(#[from] ExtractError), > } > > -/// Extract the rootfs of an OCI image tar and return the image config. > +/// Extract the rootfs of an OCI image tar and return its execution parameters. > /// > /// # Arguments > /// > @@ -109,6 +109,11 @@ pub enum ProxmoxOciError { > /// * `rootfs_path` - Destination path where the rootfs will be extracted to > /// * `arch` - Optional CPU architecture used to pick the first matching manifest from a multi-arch > /// image index. If `None`, the first manifest will be used. > +/// > +/// # Returns > +/// > +/// On success, this returns the optional container execution parameters > +/// if present in the image configuration. > pub fn parse_and_extract_image>( > oci_tar_path: P, > rootfs_path: P, > -- > 2.47.3