[PATCH manager 1/1] ui: processor edit: allow setting 8 sockets

[PATCH manager 1/1] ui: processor edit: allow setting 8 sockets

[Maximiliano Sandoval]

As per our NUMA documentation [1]:

> If the NUMA option is used, it is recommended to set the number of sockets to
> the number of nodes of the host system.

Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
Xeon Platinum 8160 and EPYC 73F3.

The schema at qemu-server does not limit the socket amount. However, $MAX_NUMA
is hard-coded to 8 at qemu-server's Memory.pm , so we bump it to 8 to be on the
safe side.

[1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Notes:
    Differences from v1:
    - Set the maxValue to 8

 www/manager6/qemu/ProcessorEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
index 719f771a7..1afc1fd78 100644
--- a/www/manager6/qemu/ProcessorEdit.js
+++ b/www/manager6/qemu/ProcessorEdit.js
@@ -129,7 +129,7 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
             xtype: 'proxmoxintegerfield',
             name: 'sockets',
             minValue: 1,
-            maxValue: 4,
+            maxValue: 8,
             value: '1',
             fieldLabel: gettext('Sockets'),
             allowBlank: false,
-- 
2.47.3

Re: [PATCH manager 1/1] ui: processor edit: allow setting 8 sockets

[Maximiliano Sandoval]

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> As per our NUMA documentation [1]:
>
>> If the NUMA option is used, it is recommended to set the number of sockets to
>> the number of nodes of the host system.
>
> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
> Xeon Platinum 8160 and EPYC 73F3.
>
> The schema at qemu-server does not limit the socket amount. However, $MAX_NUMA
> is hard-coded to 8 at qemu-server's Memory.pm , so we bump it to 8 to be on the
> safe side.
>
> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

This is v2 actually.

-- 
Maximiliano

Re: [PATCH manager 1/1] ui: processor edit: allow setting 8 sockets

[Dominik Csapak]

if the backend does not have an upper limit, shouldn't we use the same
behavior in the frontend?

AFAICS two issues arise by having a lower value here than the backend:
* we have to raise this (probably) again in the future
* a config with a higher value cannot be edited in the gui
   (because it get's invalid)

So i'd prefer just to remove the maxValue here completely.

If there is any detrimental effect when having to much sockets
configured, we could add a warning e.g. when the sockets
is > 8.

On 7/6/26 1:47 PM, Maximiliano Sandoval wrote:
> As per our NUMA documentation [1]:
> 
>> If the NUMA option is used, it is recommended to set the number of sockets to
>> the number of nodes of the host system.
> 
> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
> Xeon Platinum 8160 and EPYC 73F3.
> 
> The schema at qemu-server does not limit the socket amount. However, $MAX_NUMA
> is hard-coded to 8 at qemu-server's Memory.pm , so we bump it to 8 to be on the
> safe side.
> 
> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Notes:
>      Differences from v1:
>      - Set the maxValue to 8
> 
>   www/manager6/qemu/ProcessorEdit.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
> index 719f771a7..1afc1fd78 100644
> --- a/www/manager6/qemu/ProcessorEdit.js
> +++ b/www/manager6/qemu/ProcessorEdit.js
> @@ -129,7 +129,7 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
>               xtype: 'proxmoxintegerfield',
>               name: 'sockets',
>               minValue: 1,
> -            maxValue: 4,
> +            maxValue: 8,
>               value: '1',
>               fieldLabel: gettext('Sockets'),
>               allowBlank: false,