From: David Riley <d.riley@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs v2 10/12] ha-manager: rules: improve resource affinity rule short description
Date: Mon, 13 Jul 2026 14:44:03 +0200 [thread overview]
Message-ID: <dd4b1acf-c2c7-4d85-8fb5-c88fb10ee0e5@proxmox.com> (raw)
In-Reply-To: <20260602100226.180071-11-d.kral@proxmox.com>
Looks good to me.
consider this:
Reviewed-by: David Riley <d.riley@proxmox.com>
On 6/2/26 12:02 PM, Daniel Kral wrote:
> For conciseness, make the following improvements to the resource
> affinity rule short description in a single patch:
>
> - Add newline to separate most important information from additional
> nice-to-have information.
> - Use the same order of affinity types as in the separate "Resource
> affinity rules" section.
> - Use the word 'must' to highlight that resource affinity rules are
> currently always strict.
>
> Signed-off-by: Daniel Kral<d.kral@proxmox.com>
> ---
> changes since v1:
> - new
>
> ha-manager.adoc | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/ha-manager.adoc b/ha-manager.adoc
> index d34916e..479b539 100644
> --- a/ha-manager.adoc
> +++ b/ha-manager.adoc
> @@ -709,10 +709,11 @@ include::generated/ha-rules-opts.adoc[]
> | HA Rule Type | Description
> | `node-affinity` | Places affinity from one or more HA resources to one or
> more nodes.
> -| `resource-affinity` | Places affinity between two or more HA resources. The
> -affinity `negative` specifies that HA resources are to be kept on separate
> -nodes, while the affinity `positive` specifies that HA resources are to be kept
> -on the same node.
> +| `resource-affinity` | Places affinity between two or more HA resources.
> +
> +The affinity `positive` specifies that HA resources must be kept on the same
> +node, while the affinity `negative` specifies that HA resources must be kept on
> +separate nodes.
> |===========================================================
>
> [[ha_manager_node_affinity_rules]]
next prev parent reply other threads:[~2026-07-13 12:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 10:01 [PATCH-SERIES docs/ha-manager/manager v2 00/12] Negative Node Affinity Rules Daniel Kral
2026-06-02 10:01 ` [PATCH ha-manager v2 01/12] rules: node affinity: add affinity property to node affinity rules Daniel Kral
2026-06-02 10:01 ` [PATCH ha-manager v2 02/12] rules: rename ambiguous argument nodes to cluster nodes Daniel Kral
2026-07-13 12:41 ` David Riley
2026-06-02 10:01 ` [PATCH ha-manager v2 03/12] rules: node affinity: implement negative node affinity rules Daniel Kral
2026-07-13 12:43 ` David Riley
2026-07-14 7:36 ` Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 04/12] ui: ha: node affinity: handle non-existent nodes Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 05/12] ui: ha: node affinity: do update node selection all at once Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 06/12] ui: ha: node affinity: move node priority selector into separate component Daniel Kral
2026-07-13 12:43 ` David Riley
2026-07-14 7:57 ` Daniel Kral
2026-07-14 8:51 ` David Riley
2026-06-02 10:01 ` [PATCH manager v2 07/12] ui: ha: node affinity: allow setting affinity for node affinity rules Daniel Kral
2026-07-13 12:43 ` David Riley
2026-07-14 8:39 ` Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 08/12] ui: ha: node affinity: do not send default node affinity rule values Daniel Kral
2026-07-13 12:43 ` David Riley
2026-06-02 10:01 ` [PATCH docs v2 09/12] ha-manager: rules: use the correct article for terms starting with HA Daniel Kral
2026-07-13 12:43 ` David Riley
2026-06-02 10:01 ` [PATCH docs v2 10/12] ha-manager: rules: improve resource affinity rule short description Daniel Kral
2026-07-13 12:44 ` David Riley [this message]
2026-06-02 10:01 ` [PATCH docs v2 11/12] ha-manager: rules: adapt rule configuration examples Daniel Kral
2026-07-13 12:44 ` David Riley
2026-06-02 10:01 ` [PATCH docs v2 12/12] ha-manager: rules: add negative node affinity rule descriptions Daniel Kral
2026-07-13 12:44 ` David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4b1acf-c2c7-4d85-8fb5-c88fb10ee0e5@proxmox.com \
--to=d.riley@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox