public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs v2 09/12] ha-manager: rules: use the correct article for terms starting with HA
Date: Mon, 13 Jul 2026 14:43:57 +0200	[thread overview]
Message-ID: <84f7a9d7-9103-4b37-8c5a-01aa19985a5a@proxmox.com> (raw)
In-Reply-To: <20260602100226.180071-10-d.kral@proxmox.com>

On 6/2/26 12:02 PM, Daniel Kral wrote:
> The correct article four any term starting with "HA" is always 'an',
> since the H is silent and therefore becomes a vowel sound.


But is it really silent? Is it not because
"Its name in English is aitch (pronounced /eɪtʃ/, plural aitches)" [0]

And therefore it should be "an HA ..."? But no hard feelings just wondering.

Otherwise it looks good to me.
Consider this:
Reviewed-by: David Riley <d.riley@proxmox.com>

[0] https://en.wikipedia.org/wiki/H

> Signed-off-by: Daniel Kral<d.kral@proxmox.com>
> ---
> changes since v1:
> - new
>
>   ha-manager.adoc | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/ha-manager.adoc b/ha-manager.adoc
> index 7365ed0..d34916e 100644
> --- a/ha-manager.adoc
> +++ b/ha-manager.adoc
> @@ -719,9 +719,9 @@ on the same node.
>   Node Affinity Rules
>   ^^^^^^^^^^^^^^^^^^^
>   
> -By default, a HA resource is able to run on any cluster node, but a common
> -requirement is that a HA resource should run on a specific node. That can be
> -implemented by defining a HA node affinity rule to make the HA resource
> +By default, an HA resource is able to run on any cluster node, but a common
> +requirement is that an HA resource should run on a specific node. That can be
> +implemented by defining an HA node affinity rule to make the HA resource
>   `vm:100` prefer the node `node1`:
>   
>   ----
> @@ -730,8 +730,8 @@ implemented by defining a HA node affinity rule to make the HA resource
>   
>   By default, node affinity rules are not strict, i.e., if there is none of the
>   specified nodes available, the HA resource can also be moved to other nodes.
> -If, on the other hand, a HA resource must be restricted to the specified nodes,
> -then the node affinity rule must be set to be strict.
> +If, on the other hand, an HA resource must be restricted to the specified
> +nodes, then the node affinity rule must be set to be strict.
>   
>   In the previous example, the node affinity rule can be modified to restrict the
>   resource `vm:100` to be only on `node1`:
> @@ -823,8 +823,8 @@ separate nodes:
>   
>   Other than node affinity rules, resource affinity rules are strict by default,
>   i.e., if the constraints imposed by the resource affinity rules cannot be met
> -for a HA resource, the HA Manager will put the HA resource in recovery state in
> -case of a failover or in error state elsewhere.
> +for an HA resource, the HA Manager will put the HA resource in recovery state
> +in case of a failover or in error state elsewhere.
>   
>   The above commands created the following rules in the rules configuration file:
>   
> @@ -905,9 +905,9 @@ Currently, HA rules are checked for the following feasibility tests:
>     resources as a negative HA resources affinity rule. That is, two or more HA
>     resources cannot be kept together and separate at the same time.
>   
> -* An HA resource can only be part of a HA node affinity rule and a HA resource
> -  affinity rule at the same time, if the HA node affinity rule has a single
> -  priority class.
> +* An HA resource can only be part of an HA node affinity rule and an HA
> +  resource affinity rule at the same time, if the HA node affinity rule has a
> +  single priority class.
>   
>   * The HA resources of a positive HA resource affinity rule can only be part of
>     a single HA node affinity rule at most.




  reply	other threads:[~2026-07-13 12:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 10:01 [PATCH-SERIES docs/ha-manager/manager v2 00/12] Negative Node Affinity Rules Daniel Kral
2026-06-02 10:01 ` [PATCH ha-manager v2 01/12] rules: node affinity: add affinity property to node affinity rules Daniel Kral
2026-06-02 10:01 ` [PATCH ha-manager v2 02/12] rules: rename ambiguous argument nodes to cluster nodes Daniel Kral
2026-07-13 12:41   ` David Riley
2026-06-02 10:01 ` [PATCH ha-manager v2 03/12] rules: node affinity: implement negative node affinity rules Daniel Kral
2026-07-13 12:43   ` David Riley
2026-07-14  7:36     ` Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 04/12] ui: ha: node affinity: handle non-existent nodes Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 05/12] ui: ha: node affinity: do update node selection all at once Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 06/12] ui: ha: node affinity: move node priority selector into separate component Daniel Kral
2026-07-13 12:43   ` David Riley
2026-07-14  7:57     ` Daniel Kral
2026-07-14  8:51       ` David Riley
2026-06-02 10:01 ` [PATCH manager v2 07/12] ui: ha: node affinity: allow setting affinity for node affinity rules Daniel Kral
2026-07-13 12:43   ` David Riley
2026-07-14  8:39     ` Daniel Kral
2026-06-02 10:01 ` [PATCH manager v2 08/12] ui: ha: node affinity: do not send default node affinity rule values Daniel Kral
2026-07-13 12:43   ` David Riley
2026-06-02 10:01 ` [PATCH docs v2 09/12] ha-manager: rules: use the correct article for terms starting with HA Daniel Kral
2026-07-13 12:43   ` David Riley [this message]
2026-06-02 10:01 ` [PATCH docs v2 10/12] ha-manager: rules: improve resource affinity rule short description Daniel Kral
2026-07-13 12:44   ` David Riley
2026-06-02 10:01 ` [PATCH docs v2 11/12] ha-manager: rules: adapt rule configuration examples Daniel Kral
2026-07-13 12:44   ` David Riley
2026-06-02 10:01 ` [PATCH docs v2 12/12] ha-manager: rules: add negative node affinity rule descriptions Daniel Kral
2026-07-13 12:44   ` David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84f7a9d7-9103-4b37-8c5a-01aa19985a5a@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal