From: Friedrich Weber <f.weber@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH cluster 3/5] api: add token timeout and warning level to cluster join info
Date: Fri, 17 Apr 2026 10:33:48 +0200 [thread overview]
Message-ID: <dbbfa72c-5cb0-4c85-b9d3-d616810b0382@proxmox.com> (raw)
In-Reply-To: <20260330144321.321072-4-m.koeppl@proxmox.com>
On 30/03/2026 16:46, Michael Köppl wrote:
> The token timeout in seconds and the warning level provide additional
> information for users regarding the expected token timeout in seconds
> after adding an additional node and whether changing the token
> coefficient is recommended.
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> I'm not quite sure regarding this one, so please feel free to provide
> feedback here. I decided against simply returning the same warning
> message as in pvecm here because I wanted to avoid returning a warning
> message with a URL from the API. However, I still wanted to provide
> information regarding the high token timeout to users who call the API
> directly. These 2 fields give enough flexibility for the web UI while
> still returning documented properties.
Duplicating the error messages in backend and frontend doesn't seem that
nice indeed, but it does have the benefit that the frontend messages are
translatable, right? I think that's desirable, so if there is no better
way to achieve this, IMO the duplication seems worth it.
next prev parent reply other threads:[~2026-04-17 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 14:43 [PATCH cluster/manager 0/5] add warning messages for high token timeouts in clusters Michael Köppl
2026-03-30 14:43 ` [PATCH cluster 1/5] add functions to determine warning level for high token timeouts Michael Köppl
2026-04-17 8:33 ` Friedrich Weber
2026-04-17 8:33 ` Friedrich Weber
2026-03-30 14:43 ` [PATCH cluster 2/5] pvecm: warn users of high token timeouts when using nodes command Michael Köppl
2026-04-17 8:33 ` Friedrich Weber
2026-03-30 14:43 ` [PATCH cluster 3/5] api: add token timeout and warning level to cluster join info Michael Köppl
2026-04-17 8:33 ` Friedrich Weber [this message]
2026-03-30 14:43 ` [PATCH manager 4/5] ui: cluster info: move initialization of items to initComponent Michael Köppl
2026-04-17 8:33 ` Friedrich Weber
2026-03-30 14:43 ` [PATCH manager 5/5] ui: cluster info: warn users of high token timeout in join info Michael Köppl
2026-04-17 8:34 ` Friedrich Weber
2026-04-17 8:33 ` [PATCH cluster/manager 0/5] add warning messages for high token timeouts in clusters Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbbfa72c-5cb0-4c85-b9d3-d616810b0382@proxmox.com \
--to=f.weber@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox