Re: [PATCH manager 5/5] ui: cluster info: warn users of high token timeout in join info

[Friedrich Weber <f.weber@proxmox.com>]

On 30/03/2026 16:47, Michael Köppl wrote:
> If another node would increase Corosync's token timeout to a level that
> might affect the stability of the cluster, display a warning hint to
> users, pointing them to the documentation section about changing the
> token coefficient, allowing them to make an informed change before
> another node.
> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  www/manager6/dc/Cluster.js     |  4 ++++
>  www/manager6/dc/ClusterEdit.js | 37 ++++++++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+)
> 
> diff --git a/www/manager6/dc/Cluster.js b/www/manager6/dc/Cluster.js
> index 2ec5588c3..00138f328 100644
> --- a/www/manager6/dc/Cluster.js
> +++ b/www/manager6/dc/Cluster.js
> @@ -91,6 +91,8 @@ Ext.define('PVE.ClusterAdministration', {
>                      vm.set('totem', data.totem);
>                      vm.set('isInCluster', !!data.totem.cluster_name);
>                      vm.set('nodelist', data.nodelist);
> +                    vm.set('expected_timeout', data.expected_timeout);
> +                    vm.set('timeout_warning_level', data.timeout_warning_level);
>  
>                      let nodeinfo = data.nodelist.find((el) => el.name === data.preferred_node);
>  
> @@ -133,6 +135,8 @@ Ext.define('PVE.ClusterAdministration', {
>                              peerLinks: vm.get('preferred_node.peerLinks'),
>                              ring_addr: vm.get('preferred_node.ring_addr'),
>                              totem: vm.get('totem'),
> +                            expected_timeout: vm.get('expected_timeout'),
> +                            timeout_warning_level: vm.get('timeout_warning_level'),
>                          },
>                      });
>                  },
> diff --git a/www/manager6/dc/ClusterEdit.js b/www/manager6/dc/ClusterEdit.js
> index aff1515ab..a1720dbca 100644
> --- a/www/manager6/dc/ClusterEdit.js
> +++ b/www/manager6/dc/ClusterEdit.js
> @@ -55,6 +55,8 @@ Ext.define('PVE.ClusterInfoWindow', {
>          ipAddress: undefined,
>          fingerprint: undefined,
>          totem: {},
> +        expected_timeout: undefined,
> +        timeout_warning_level: undefined,
>      },
>  
>      initComponent: function () {
> @@ -113,6 +115,41 @@ Ext.define('PVE.ClusterInfoWindow', {
>              },
>          );
>  
> +        if (joinInfo.expected_timeout && joinInfo.timeout_warning_level) {
> +            let level;
> +            if (joinInfo.timeout_warning_level === 'change-strongly-recommended') {
> +                level = gettext('Changing token coefficient is strongly recommended');
> +            } else if (joinInfo.timeout_warning_level === 'change-recommended') {
> +                level = gettext('Changing token coefficient is recommended');
> +            } else if (joinInfo.timeout_warning_level === 'optimize') {
> +                level = gettext('Token coefficient can be optimized');
> +            }
> +
> +            let msg = Ext.String.format(
> +                gettext(
> +                    "Adding another node will increase the sum of Corosync's token and consensus timeout to {0}s. {1}." +
> +                        ' See {2} for details.',
> +                ),
> +                joinInfo.expected_timeout,
> +                level,
> +                '<a target="_blank" href="https://pve.proxmox.com/pve-docs/chapter-pvecm.html#_changing_the_token_coefficient">the documentation</a>',

This should probably link to the local copy of the docs.

> +            );
> +
> +            me.items.push({
> +                xtype: 'container',
> +                border: false,
> +                padding: '0 10 10 10',
> +                items: [
> +                    {
> +                        itemId: 'joinInfoWarningHint',
> +                        xtype: 'displayfield',
> +                        userCls: 'pmx-hint',
> +                        value: msg,
> +                    },
> +                ],
> +            });
> +        }
> +
>          me.callParent();
>      },
>      dockedItems: [