Re: [PATCH pve-manager] fix #5001: ui: add context menu with bulk actions for pools in resource tree

[Dominik Csapak <d.csapak@proxmox.com>]

On 11/4/26 11:57 AM, Jonas Theisen wrote:
> On 11/3/26 14:37, Dominik Csapak wrote:
>> patch looks good to me, one high level thing and one
>> comment inline:
>>
>> if you send multiple patches, please number them, so it's easier to
>> apply the whole thread, e.g. with `b4 shazam`
>>
>> e.g. if you have both patches on the same branch,
>>
>> `git send-email` or `git format-patch` should do this for you
> 
> I intentionally did not do that since i thought the two patches
> are only related by their targeted component but are not dependent
> on each other in any way.
> Will keep that in mind for v2.

that would also be ok, but then send them please as completely
independent patches, not within a single thread.

this makes it much clearer in most mail clients/tools that
they are separate

>>
>>
>>> <snip>
>>> +
>>> +        me.title = `${gettext('Pool')} '${me.pool}'`;
>>> +        if (PVE.ClusterName?.length) {
>>> +            me.title += ` (${PVE.ClusterName})`;
>>> +        }
>>> +
>>
>> i know this is copied from the other cmd menus here,
>> but does it really make sense?
>>
>> for the datacenter it makes (kinda) sense but for a pool
>> not really
>>
>> i'd just leave it out and use `Pool <name>` there
> 
> Agreed and also applied that to the Tag menu in v2 as mentioned.
>>
>>> +        me.extraHandlerArgs = {
>>> +            prefilterPool: me.pool,
>>> +        };
>>> +
>>> +        me.callParent();
>>> +    },
>>> +});
>>> diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/ 
>>> BulkAction.js
>>> index 2e3066a3..7e58fb3f 100644
>>> --- a/www/manager6/window/BulkAction.js
>>> +++ b/www/manager6/window/BulkAction.js
>>> @@ -557,6 +557,9 @@ Ext.define('PVE.window.BulkAction', {
>>>           if (me.prefilterIncludeTag) {
>>> me.down('#includetagfilter').setValue(me.prefilterIncludeTag);
>>>           }
>>> +        if (me.prefilterPool) {
>>> +            me.down('#poolfilter').setValue(me.prefilterPool);
>>> +        }
>>>             form.on('validitychange', function () {
>>>               let valid = form.isValid();
>>
>