Re: [PATCH pve-manager] fix #5001: ui: add context menu with bulk actions for pools in resource tree

[Dominik Csapak <d.csapak@proxmox.com>]

patch looks good to me, one high level thing and one
comment inline:

if you send multiple patches, please number them, so it's easier to
apply the whole thread, e.g. with `b4 shazam`

e.g. if you have both patches on the same branch,

`git send-email` or `git format-patch` should do this for you


On 10/30/26 11:07 AM, Jonas Theisen wrote:
> The pool view groups guests by their pool, but unlike the tag view it
> offers no context menu on the pool tree-node itself. Add one with the
> same guest bulk actions as the datacenter and tag menus.
> 
> The bulk action window opens with the pool filter pre-selected for the
> pool the menu was opened on. Only guests that are direct members of
> that pool are selected, guests in nested sub-pools are not, matching
> how the pool filter works when set manually.
> 
> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5001
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>   www/manager6/Utils.js             |  4 ++++
>   www/manager6/dc/CmdMenu.js        | 26 ++++++++++++++++++++++++++
>   www/manager6/window/BulkAction.js |  3 +++
>   3 files changed, 33 insertions(+)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 8b99371d..ced25763 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -1630,6 +1630,10 @@ Ext.define('PVE.Utils', {
>                   menu = Ext.create('PVE.dc.TagCmdMenu', {
>                       tag: record.data.tag,
>                   });
> +            } else if (type === 'pool') {
> +                menu = Ext.create('PVE.dc.PoolCmdMenu', {
> +                    pool: record.data.pool,
> +                });
>               } else if (record?.isRoot()) {
>                   menu = Ext.create('PVE.dc.CmdMenu', {
>                       pveSelNode: record,
> diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
> index 5bb4d7d1..f47132ee 100644
> --- a/www/manager6/dc/CmdMenu.js
> +++ b/www/manager6/dc/CmdMenu.js
> @@ -127,3 +127,29 @@ Ext.define('PVE.dc.TagCmdMenu', {
>           me.callParent();
>       },
>   });
> +
> +Ext.define('PVE.dc.PoolCmdMenu', {
> +    extend: 'PVE.dc.CmdMenu',
> +    xtype: 'poolCmdMenu',
> +
> +    minWidth: 220,
> +
> +    initComponent: function () {
> +        let me = this;
> +
> +        if (!me.pool) {
> +            throw 'no pool specified';
> +        }
> +
> +        me.title = `${gettext('Pool')} '${me.pool}'`;
> +        if (PVE.ClusterName?.length) {
> +            me.title += ` (${PVE.ClusterName})`;
> +        }
> +

i know this is copied from the other cmd menus here,
but does it really make sense?

for the datacenter it makes (kinda) sense but for a pool
not really

i'd just leave it out and use `Pool <name>` there

> +        me.extraHandlerArgs = {
> +            prefilterPool: me.pool,
> +        };
> +
> +        me.callParent();
> +    },
> +});
> diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
> index 2e3066a3..7e58fb3f 100644
> --- a/www/manager6/window/BulkAction.js
> +++ b/www/manager6/window/BulkAction.js
> @@ -557,6 +557,9 @@ Ext.define('PVE.window.BulkAction', {
>           if (me.prefilterIncludeTag) {
>               me.down('#includetagfilter').setValue(me.prefilterIncludeTag);
>           }
> +        if (me.prefilterPool) {
> +            me.down('#poolfilter').setValue(me.prefilterPool);
> +        }
>   
>           form.on('validitychange', function () {
>               let valid = form.isValid();