public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Jonas Theisen <j.theisen@proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime
Date: Sun, 15 Nov 2026 23:22:00 +0100	[thread overview]
Message-ID: <c606eb70-7097-48b5-af77-5564524d42f2@proxmox.com> (raw)
In-Reply-To: <ca5bfaef-27d8-4621-83a2-f1cdc11ef700@proxmox.com>

Am 09.09.26 um 11:40 schrieb Jonas Theisen:
> For change detection, we only need a resolution of 0.01 (since we want
> to use the percentage as integer) so check that the difference of old and new
> is bigger than 0.9% .

maybe "is bigger than 0.009 (0.9%)" 

>> Ok so I think lowering the threshold to 0.01% difference probably
>> does not have the effect I'd hoped for (i.e. not refreshing too often)
>>
>> So I'd either render the tooltip as whole percentage too, or
>> use 0.1% in both cases as a middle ground.
>>
>> What do you think?
> 
> My personal preference would be to render the tooltip as
> rounded percentage since in my head it is just a quick view option.
> If the user wants the exact number, they can look into the status page.

rendering <0.1% might be also an option fwiw. But just rounded to 1 digit
right to the comma point would be fine too IMO.




  reply	other threads:[~2026-11-15 22:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  8:12 [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime Dominik Csapak
2026-01-23  8:12 ` [pve-devel] [PATCH manager v3 2/2] ui: resource tree: only fire 'refresh' event when something changed Dominik Csapak
2026-08-31  9:26 ` [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime Dominik Csapak
2026-09-09  9:22 ` Jonas Theisen
2026-09-09  9:29   ` Dominik Csapak
2026-09-09  9:40     ` Jonas Theisen
2026-11-15 22:22       ` Thomas Lamprecht [this message]
2026-11-16  8:57 ` superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c606eb70-7097-48b5-af77-5564524d42f2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal