From: Jonas Theisen <j.theisen@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime
Date: Wed, 9 Sep 2026 11:22:30 +0200 [thread overview]
Message-ID: <38f5e579-207d-4e17-a5af-e94bc8e7b98d@proxmox.com> (raw)
In-Reply-To: <20260123081322.644536-1-d.csapak@proxmox.com>
On 1/23/26 09:12, Dominik Csapak wrote:
> the resource store has a field 'diskuse' which it calculates on update.
> Use that instead of calculating the value ourselves everytime.
>
> For change detection, we only need a resolution of 0.01 (since we want
> to use the percentage as integer) so check that the difference of old and new
> is bigger than 0.9% .
>
> This works because we only overwrite the values in the treestore if
> anything changed, so multiple small changes to the diskuse will not be
> lost.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> <snip>
Applied and tested the patch on top of current pve-manager 9.2.18
Tested VM state changes and storage usage changes on a single node
Problem: The tooltip style usage shown when hovering over a storage
reports the usage with two decimal places so per mille.
Due to the update logic only triggering on changes of 1% or greater,
a change smaller than that will cause the tooltip to get out of sync
from the actual usage reported by the status page.
--
Tested-by: Jonas Theisen <j.theisen@proxmox.com>
next prev parent reply other threads:[~2026-09-09 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 8:12 [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime Dominik Csapak
2026-01-23 8:12 ` [pve-devel] [PATCH manager v3 2/2] ui: resource tree: only fire 'refresh' event when something changed Dominik Csapak
2026-08-31 9:26 ` [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime Dominik Csapak
2026-09-09 9:22 ` Jonas Theisen [this message]
2026-09-09 9:29 ` Dominik Csapak
2026-09-09 9:40 ` Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f5e579-207d-4e17-a5af-e94bc8e7b98d@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox