public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets
Date: Fri, 10 Jul 2026 10:51:45 +0200	[thread overview]
Message-ID: <bf368138-362d-4906-b583-8bca1b85b529@proxmox.com> (raw)
In-Reply-To: <s8o33xrcjw5.fsf@toolbox>



On 7/10/26 10:45 AM, Maximiliano Sandoval wrote:
> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> 
>> The schema at qemu-server does not limit the socket amount.
>>
>> As per our NUMA documentation [1]:
>>
>>> If the NUMA option is used, it is recommended to set the number of sockets to
>>> the number of nodes of the host system.
>>
>> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are
>> Xeon Platinum 8160 and EPYC 73F3.
>>
>> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> 
> The commit title should be " ui: processor edit: allow setting 4 sockets".
> 

IMO both titles don't make sense, since 4 is already allowed before the
patch and yes 8 is allowed afterwards but so is 16,32,etc.


and we don't have to argument with numa in the commit message
e.g. it could be enought explain it like this:

suggestion:

ui: processor: edit: remove UI limit on socket count

The backend imposes no limit on the number of sockets, so the UI
should not either. Remove the arbitrary cap and let users set
socket counts as high as the backend allows.




  reply	other threads:[~2026-07-10  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10  8:44 [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets Maximiliano Sandoval
2026-07-10  8:46 ` Maximiliano Sandoval
2026-07-10  8:51   ` Dominik Csapak [this message]
2026-07-10  9:50     ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf368138-362d-4906-b583-8bca1b85b529@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal