From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E5EA21FF0E7 for ; Fri, 10 Jul 2026 10:52:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1E57021476; Fri, 10 Jul 2026 10:52:19 +0200 (CEST) Message-ID: Date: Fri, 10 Jul 2026 10:51:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v3 1/1] ui: processor edit: allow setting 8 sockets To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260710084423.164757-1-m.sandoval@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783673494439 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LJK72QF3ANUN7WYEG3KJRL2UMVJQNSKR X-Message-ID-Hash: LJK72QF3ANUN7WYEG3KJRL2UMVJQNSKR X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/10/26 10:45 AM, Maximiliano Sandoval wrote: > Maximiliano Sandoval writes: > >> The schema at qemu-server does not limit the socket amount. >> >> As per our NUMA documentation [1]: >> >>> If the NUMA option is used, it is recommended to set the number of sockets to >>> the number of nodes of the host system. >> >> Nowadays, it is common to find CPU models with 8 NUMA nodes. Two examples are >> Xeon Platinum 8160 and EPYC 73F3. >> >> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_numa >> >> Signed-off-by: Maximiliano Sandoval > > The commit title should be " ui: processor edit: allow setting 4 sockets". > IMO both titles don't make sense, since 4 is already allowed before the patch and yes 8 is allowed afterwards but so is 16,32,etc. and we don't have to argument with numa in the commit message e.g. it could be enought explain it like this: suggestion: ui: processor: edit: remove UI limit on socket count The backend imposes no limit on the number of sockets, so the UI should not either. Remove the arbitrary cap and let users set socket counts as high as the backend allows.