From: Filip Schauer <f.schauer@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: superseded: Re: [PATCH manager v3 3/3] ui: lxc/MPEdit: add "idmap" option
Date: Wed, 13 May 2026 11:33:04 +0200 [thread overview]
Message-ID: <ba3bf5f5-d160-4abf-8227-536fba2bade8@proxmox.com> (raw)
In-Reply-To: <fa5rswllu25altbp4jtwbvkoz6uky3535cedaxv4p6fkozbdo5@at5eci5zkcsv>
On 12/05/2026 16:55, Wolfgang Bumiller wrote:
> Seems better than v1. Some things to consider, though:
>
> Checking and then unchecking `passthrough` wipes the list.
> I wonder if the last state of the list should be kept around as long as
> the window is open?
> On the other hand, at least it's a quick and easy way clear and get rid
> of id mapping, but users would probably be looking for an explicit clear
> button instead. Then again the list cannot be huge anyway, so it's not
> really important. (Although the kernel has raised the limit from 5 to
> 340 lines long ago...)
Added a "Clear" button next to "Add" and the "Passthrough" checkbox no
longer wipes the list in v4:
https://lore.proxmox.com/pve-devel/20260513092830.47167-1-f.schauer@proxmox.com
prev parent reply other threads:[~2026-05-13 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 14:01 [PATCH manager v3 0/3] ui: add container mount point idmapping Filip Schauer
2026-05-12 14:01 ` [PATCH manager v3 1/3] ui: lxc/MPEdit: remove duplicate "mp" assignment Filip Schauer
2026-05-12 14:01 ` [PATCH manager v3 2/3] d/control: bump versioned dependency for pve-container Filip Schauer
2026-05-12 14:01 ` [PATCH manager v3 3/3] ui: lxc/MPEdit: add "idmap" option Filip Schauer
2026-05-12 14:57 ` Wolfgang Bumiller
2026-05-13 9:33 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3bf5f5-d160-4abf-8227-536fba2bade8@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox