From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5365E1FF13A for ; Wed, 13 May 2026 11:33:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C2E16327; Wed, 13 May 2026 11:33:41 +0200 (CEST) Message-ID: Date: Wed, 13 May 2026 11:33:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: superseded: Re: [PATCH manager v3 3/3] ui: lxc/MPEdit: add "idmap" option To: Wolfgang Bumiller References: <20260512140126.171755-1-f.schauer@proxmox.com> <20260512140126.171755-4-f.schauer@proxmox.com> Content-Language: en-US From: Filip Schauer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778664670993 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: P3EAOFAZEH6BATWDWM4RANY4QDQ3B2YQ X-Message-ID-Hash: P3EAOFAZEH6BATWDWM4RANY4QDQ3B2YQ X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 12/05/2026 16:55, Wolfgang Bumiller wrote: > Seems better than v1. Some things to consider, though: > > Checking and then unchecking `passthrough` wipes the list. > I wonder if the last state of the list should be kept around as long as > the window is open? > On the other hand, at least it's a quick and easy way clear and get rid > of id mapping, but users would probably be looking for an explicit clear > button instead. Then again the list cannot be huge anyway, so it's not > really important. (Although the kernel has raised the limit from 5 to > 340 lines long ago...) Added a "Clear" button next to "Add" and the "Passthrough" checkbox no longer wipes the list in v4: https://lore.proxmox.com/pve-devel/20260513092830.47167-1-f.schauer@proxmox.com