[pve-devel] [PATCH pve_flutter_frontend 1/2] fix typos

[pve-devel] [PATCH pve_flutter_frontend 1/2] fix typos

[Michael Köppl]

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
While reviewing another series, I noticed a few typos in user-facing
errors. While I was at it, also fixed typos for a few variables.

 README.md                                        | 2 +-
 lib/pages/main_layout_slim.dart                  | 2 +-
 lib/widgets/pve_console_menu_widget.dart         | 2 +-
 lib/widgets/pve_guest_overview_header.dart       | 4 ++--
 lib/widgets/pve_node_overview.dart               | 2 +-
 lib/widgets/pve_resource_status_chip_widget.dart | 2 +-
 lib/widgets/pve_rrd_chart_widget.dart            | 6 +++---
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index b395a3a..c910ad9 100644
--- a/README.md
+++ b/README.md
@@ -95,7 +95,7 @@ $ flutter run -d chrome --web-port=35000
 
 
 NOTE: without setting a fixed port flutter uses a random one, as chrome binds
- certificate expections and local browser storage to a (protocol, host, port)
+ certificate exceptions and local browser storage to a (protocol, host, port)
  tuple, this means that we'd lose all saved settings etc. every time else
 
 ### Use reverse proxy to allow connections to PVE and the App over the same port
diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
index 322bcac..20f3209 100644
--- a/lib/pages/main_layout_slim.dart
+++ b/lib/pages/main_layout_slim.dart
@@ -622,7 +622,7 @@ class MobileResourceOverview extends StatelessWidget {
               itemBuilder: (context, index) {
                 final resource = fResources[index];
                 StatelessWidget listWidget = const ListTile(
-                  title: Text('Unkown resource type'),
+                  title: Text('Unknown resource type'),
                 );
                 if (const ['lxc', 'qemu'].contains(resource.type)) {
                   listWidget = PveGuestListTile(resource: resource);
diff --git a/lib/widgets/pve_console_menu_widget.dart b/lib/widgets/pve_console_menu_widget.dart
index f4bd8d3..cd8c314 100644
--- a/lib/widgets/pve_console_menu_widget.dart
+++ b/lib/widgets/pve_console_menu_widget.dart
@@ -308,7 +308,7 @@ class PVEWebConsoleState extends State<PVEWebConsole> {
             // prevent back button from canceling this callback
             canPop: false,
             child: AlertDialog(
-                title: const Text('An TLS error has occurred:'),
+                title: const Text('A TLS error has occurred:'),
                 content: Column(
                   crossAxisAlignment: CrossAxisAlignment.start,
                   mainAxisSize: MainAxisSize.min,
diff --git a/lib/widgets/pve_guest_overview_header.dart b/lib/widgets/pve_guest_overview_header.dart
index 2382f2d..1da2667 100644
--- a/lib/widgets/pve_guest_overview_header.dart
+++ b/lib/widgets/pve_guest_overview_header.dart
@@ -197,7 +197,7 @@ class _PveGuestHeaderRRDPageViewState extends State<PveGuestHeaderRRDPageView> {
                   child: PveRRDChart(
                     titlePadding: const EdgeInsets.only(bottom: 80),
                     titleWidth: 150,
-                    titleAlginment: CrossAxisAlignment.end,
+                    titleAlignment: CrossAxisAlignment.end,
                     title: 'CPU (${rrdData.last.maxcpu ?? '-'})',
                     subtitle: "${(rrdData.last.cpu ?? 0).toStringAsFixed(2)}%",
                     data: rrdData.where((e) => e.cpu != null).map(
@@ -212,7 +212,7 @@ class _PveGuestHeaderRRDPageViewState extends State<PveGuestHeaderRRDPageView> {
                   child: PveRRDChart(
                     titlePadding: const EdgeInsets.only(bottom: 80),
                     titleWidth: 200,
-                    titleAlginment: CrossAxisAlignment.end,
+                    titleAlignment: CrossAxisAlignment.end,
                     title: 'Memory',
                     subtitle: Renderers.formatSize(rrdData.last.mem ?? 0),
                     data: rrdData.where((e) => e.mem != null).map(
diff --git a/lib/widgets/pve_node_overview.dart b/lib/widgets/pve_node_overview.dart
index 23f0edc..203a83d 100644
--- a/lib/widgets/pve_node_overview.dart
+++ b/lib/widgets/pve_node_overview.dart
@@ -231,7 +231,7 @@ class PveNodeOverview extends StatelessWidget {
                     children: [
                       ListTile(
                         dense: true,
-                        title: Text(status?.kversion ?? 'unkown'),
+                        title: Text(status?.kversion ?? 'unknown'),
                         subtitle: const Text('Kernel'),
                       ),
                       if (status?.cpuinfo != null)
diff --git a/lib/widgets/pve_resource_status_chip_widget.dart b/lib/widgets/pve_resource_status_chip_widget.dart
index 3a6df89..c3d3f69 100644
--- a/lib/widgets/pve_resource_status_chip_widget.dart
+++ b/lib/widgets/pve_resource_status_chip_widget.dart
@@ -46,7 +46,7 @@ class StatusChip extends StatelessWidget {
         break;
       default:
         statusColor = offlineColor;
-        statusText = 'unkown';
+        statusText = 'unknown';
     }
     return Container(
       decoration: BoxDecoration(
diff --git a/lib/widgets/pve_rrd_chart_widget.dart b/lib/widgets/pve_rrd_chart_widget.dart
index aa6406e..f5c7e5b 100644
--- a/lib/widgets/pve_rrd_chart_widget.dart
+++ b/lib/widgets/pve_rrd_chart_widget.dart
@@ -15,7 +15,7 @@ class PveRRDChart extends StatefulWidget {
   final double? staticMaximum;
   final Color? shadeColorTop;
   final Color? shadeColorBottom;
-  final CrossAxisAlignment titleAlginment;
+  final CrossAxisAlignment titleAlignment;
   final bool showMaximum;
   final bool showDuration;
   final Widget? bottomRight;
@@ -31,7 +31,7 @@ class PveRRDChart extends StatefulWidget {
     this.staticMaximum,
     this.shadeColorTop,
     this.shadeColorBottom,
-    this.titleAlginment = CrossAxisAlignment.start,
+    this.titleAlignment = CrossAxisAlignment.start,
     this.titleWidth,
     this.titlePadding,
     this.showMaximum = true,
@@ -57,7 +57,7 @@ class _PveRRDChartState extends State<PveRRDChart> {
 
     final fgColor = Theme.of(context).colorScheme.onPrimary.withOpacity(0.85);
     return Column(
-      crossAxisAlignment: widget.titleAlginment,
+      crossAxisAlignment: widget.titleAlignment,
       children: <Widget>[
         Container(
           width: widget.titleWidth,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve_flutter_frontend 2/2] ui: make LXC containers naming more consistent

[Michael Köppl]

To avoid confusion for users, consistent naming for LXC containers is
applied. Since the main screen uses the plural "Virtual Machines", LXC
containers is now also plural.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 lib/pages/main_layout_slim.dart | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
index 20f3209..f308aea 100644
--- a/lib/pages/main_layout_slim.dart
+++ b/lib/pages/main_layout_slim.dart
@@ -302,7 +302,7 @@ class MobileDashboard extends StatelessWidget {
                             size: 20,
                           ),
                           label: const Text(
-                            'Linux Containers',
+                            'LXC Containers',
                             style: TextStyle(
                                 fontWeight: FontWeight.bold,
                                 color: Colors.white),
@@ -483,7 +483,7 @@ class MobileDashboard extends StatelessWidget {
                             indent: 10,
                           ),
                           ListTile(
-                            title: const Text("LXC Container"),
+                            title: const Text("LXC Containers"),
                             trailing: Text(totalCTs.toString()),
                             leading:
                                 Icon(Renderers.getDefaultResourceIcon('lxc')),
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH proxmox_dart_api_client 1/1] fix typos

[Michael Köppl]

In addition to user-facing errors, a few internal variable names are
also fixed.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 lib/src/client.dart                             | 2 +-
 lib/src/handle_ticket_response.dart             | 7 ++++---
 lib/src/models/pve_cluster_resources_model.dart | 4 ++--
 lib/src/models/pve_nodes_lxc_status_model.dart  | 2 +-
 lib/src/models/pve_nodes_qemu_status_model.dart | 2 +-
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/src/client.dart b/lib/src/client.dart
index f597c28..889d81c 100644
--- a/lib/src/client.dart
+++ b/lib/src/client.dart
@@ -94,7 +94,7 @@ class ProxmoxApiClient extends http.BaseClient {
 
   Future<ProxmoxApiClient> finishTfaChallenge(String kind, String code) async {
     if (credentials.tfa == null) {
-      throw StateError('No tfa challange expected');
+      throw StateError('No tfa challenge expected');
     }
 
     credentials = await credentials.tfaChallenge(kind, code,
diff --git a/lib/src/handle_ticket_response.dart b/lib/src/handle_ticket_response.dart
index 7d4c650..ba2128f 100644
--- a/lib/src/handle_ticket_response.dart
+++ b/lib/src/handle_ticket_response.dart
@@ -1,11 +1,12 @@
 import 'dart:convert';
+
 import 'package:http/http.dart' as http;
 import 'package:proxmox_dart_api_client/src/credentials.dart';
 import 'package:proxmox_dart_api_client/src/extentions.dart';
 import 'package:proxmox_dart_api_client/src/tfa_challenge.dart';
 
 Credentials handleAccessTicketResponse(
-    http.Response response, Credentials unauthenicatedCredentials) {
+    http.Response response, Credentials unauthenticatedCredentials) {
   response.validate(false);
 
   final bodyJson = jsonDecode(response.body)['data'];
@@ -29,8 +30,8 @@ Credentials handleAccessTicketResponse(
   }
 
   return Credentials(
-    unauthenicatedCredentials.apiBaseUrl,
-    unauthenicatedCredentials.username,
+    unauthenticatedCredentials.apiBaseUrl,
+    unauthenticatedCredentials.username,
     ticket: ticket,
     csrfToken: csrfToken,
     expiration: time,
diff --git a/lib/src/models/pve_cluster_resources_model.dart b/lib/src/models/pve_cluster_resources_model.dart
index 1f69213..16e18df 100644
--- a/lib/src/models/pve_cluster_resources_model.dart
+++ b/lib/src/models/pve_cluster_resources_model.dart
@@ -69,7 +69,7 @@ abstract class PveClusterResourcesModel
       return PveResourceStatusType.stopped;
     }
 
-    return PveResourceStatusType.unkown;
+    return PveResourceStatusType.unknown;
   }
 }
 
@@ -109,7 +109,7 @@ class PveResourceStatusType extends EnumClass {
   static const PveResourceStatusType paused = _$paused;
   static const PveResourceStatusType suspending = _$suspending;
   static const PveResourceStatusType suspended = _$suspended;
-  static const PveResourceStatusType unkown = _$unkown;
+  static const PveResourceStatusType unknown = _$unknown;
 
   const PveResourceStatusType._(super.name);
 
diff --git a/lib/src/models/pve_nodes_lxc_status_model.dart b/lib/src/models/pve_nodes_lxc_status_model.dart
index c82574e..7f71bf9 100644
--- a/lib/src/models/pve_nodes_lxc_status_model.dart
+++ b/lib/src/models/pve_nodes_lxc_status_model.dart
@@ -49,7 +49,7 @@ abstract class PveNodesLxcStatusModel
       }
       return PveResourceStatusType.stopped;
     }
-    return PveResourceStatusType.unkown;
+    return PveResourceStatusType.unknown;
   }
 }
 
diff --git a/lib/src/models/pve_nodes_qemu_status_model.dart b/lib/src/models/pve_nodes_qemu_status_model.dart
index 8b997c1..ae82802 100644
--- a/lib/src/models/pve_nodes_qemu_status_model.dart
+++ b/lib/src/models/pve_nodes_qemu_status_model.dart
@@ -59,6 +59,6 @@ abstract class PveQemuStatusModel
       }
       return PveResourceStatusType.stopped;
     }
-    return PveResourceStatusType.unkown;
+    return PveResourceStatusType.unknown;
   }
 }
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend 1/2] fix typos

[Thomas Lamprecht]

Am 02.05.25 um 14:10 schrieb Michael Köppl:
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> While reviewing another series, I noticed a few typos in user-facing
> errors. While I was at it, also fixed typos for a few variables.

This seems to need a refresh now that I applied a few of Shan's patches
upfront, which were changing the same context this patch touches.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend 2/2] ui: make LXC containers naming more consistent

[Thomas Lamprecht]

Am 02.05.25 um 14:10 schrieb Michael Köppl:
> To avoid confusion for users, consistent naming for LXC containers is
> applied. Since the main screen uses the plural "Virtual Machines", LXC
> containers is now also plural.
> 

Hmm, I do not have hard feelings for these things, but it _is_ a case
of the RAS syndrome [0], i.e. LXC already stands for Linux Containers.

FWIW, in the web UI we mostly write just Container(s), so maybe that
would be good enough for here too?

[0]: https://en.wikipedia.org/wiki/RAS_syndrome


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend 2/2] ui: make LXC containers naming more consistent

[Michael Köppl]

On 5/7/25 10:12, Thomas Lamprecht wrote:
> Am 02.05.25 um 14:10 schrieb Michael Köppl:
>> To avoid confusion for users, consistent naming for LXC containers is
>> applied. Since the main screen uses the plural "Virtual Machines", LXC
>> containers is now also plural.
>>
> 
> Hmm, I do not have hard feelings for these things, but it _is_ a case
> of the RAS syndrome [0], i.e. LXC already stands for Linux Containers.
> 
> FWIW, in the web UI we mostly write just Container(s), so maybe that
> would be good enough for here too?
> 
> [0]: https://en.wikipedia.org/wiki/RAS_syndrome

Yes, I agree. I was mostly aiming for consistency throughout the UI, but
would also prefer "Containers" instead. Will send an updated v2. Thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend 1/2] fix typos

[Michael Köppl]

On 5/7/25 10:09, Thomas Lamprecht wrote:
> Am 02.05.25 um 14:10 schrieb Michael Köppl:
>> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
>> ---
>> While reviewing another series, I noticed a few typos in user-facing
>> errors. While I was at it, also fixed typos for a few variables.
> 
> This seems to need a refresh now that I applied a few of Shan's patches
> upfront, which were changing the same context this patch touches.

Sent a v2:
https://lore.proxmox.com/pve-devel/20250509083120.40047-1-m.koeppl@proxmox.com/T


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel