public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support
Date: Fri, 20 Nov 2026 19:51:10 +0100	[thread overview]
Message-ID: <awCTF7Ly0acZZWoo@luna.proxmox.com> (raw)
In-Reply-To: <179515721902.2281522.12185275346766103866.b4-ty@b4>

On 20.11.2026 08:42, Thomas Lamprecht wrote:
> On Thu, 19 Nov 2026 20:40:46 +0100, Gabriel Goller wrote:
> > This series adds VRF support to SDN zones and fabrics.
> > 
> > A simple zone can now use either the default VRF or a dedicated VRF. The
> > simple zone dialog has a checkbox for this and uses the default VRF by
> > default. If the checkbox is disabled, the zone creates a dedicated VRF named
> > `vrf_<zone-name>`. EVPN zones always create a dedicated VRF. BGP and OSPF
> > fabrics can select a zone and run inside its VRF.
> > 
> > [...]
> 
> Applied, thanks!
> 
> Tested on a three-node cluster with two VRF zones that use the same
> subnet, with SNAT, DHCP and a default route via a VLAN uplink. A setup
> like the existing ones still produces the same config, apart from the
> new IPv6 unreachable route in EVPN VRFs.
> 
> What I changed in your patches:
> - Static routes now require a dedicated VRF as without one, the routes
>   went into the main routing table of the host, and unchecking the VRF
>   moved existing routes there. I went that way as this we can still
>   relax easily later without breaking existing configurations. If routes
>   in the main table are wanted, a separate SDN object for static routes
>   would be the cleaner way.
> - The permission check for routes skipped zones with an empty node list,
>   which means all nodes. It now checks all nodes in that case.
> - Several OSPF fabrics in one VRF could set different options for the
>   same kind of redistributed routes, so the FRR config flipped back and
>   forth on every apply. Now the first fabric wins. In the default VRF,
>   this also means that the other fabrics' redistributions apply now,
>   not just the first one's.
> - Since your series sets up DHCP after ifreload, one failing interface
>   skipped the DHCP config of all zones, and a DHCP error skipped the FRR
>   config. Now each step runs even if the other one fails.
> - A VRF on an OVS bridge or internal port was rejected, which blocked
>   all network changes on a node with such a manual config. Only OVS
>   ports and bonds are rejected now, and the UI matches that.
> - The dnsmasq override files for the VRF were removed before stopping
>   the service, so systemd warned on every apply. They are now removed
>   after stopping it.
> - I also did some rewording and formatting.
> 
> What I added on top:
> - ifupdown2 does not enable IPv4 forwarding on VLAN interfaces by
>   default, which broke VLAN uplinks for the zone. So I added an explicit
>   forwarding option to the network API and UI. This way an admin can
>   turn it on without editing the config by hand, and we don't have to
>   enable and disable it automatically.
> - I reworked the VRF docs to walk through setting up an uplink, and
>   documented the new options.

Thanks for all these fixes, had a quick look at them and they looked good.

> Still open:
> - Host interfaces can still point to the VRF of a zone after the zone or
>   its VRF is removed. A warning on the node would help.

https://lore.proxmox.com/pve-devel/20261120183116.478378-1-g.goller@proxmox.com/

> - A VRF set on a fabric interface makes the whole SDN network config of
>   the node fail. A warning might be enough.

https://lore.proxmox.com/pve-devel/20261120185037.493949-1-g.goller@proxmox.com/

> - Conflicting OSPF settings between fabrics could be rejected in the API
>   instead of the first fabric silently winning.

Hmm this is not so easily fixable without making a breaking change. Prepared
a series, but this is for something after the release and will take a while to
get right.

> - If an OSPF or BGP fabric in a VRF uses a WireGuard interface, the
>   WireGuard peer routes still go into the main routing table.

https://lore.proxmox.com/pve-devel/20261120152657.275504-1-g.goller@proxmox.com/

> - Removing all static routes and unchecking the VRF in one go fails in
>   the UI. Doing it in two steps works.

https://lore.proxmox.com/pve-devel/20261120143944.219256-1-g.goller@proxmox.com/

> 
> [snip]




      reply	other threads:[~2026-11-20 18:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:40 [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support Gabriel Goller
2026-11-19 19:40 ` [PATCH pve-common v3 01/28] interfaces: preserve VRF membership across address family changes Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 02/28] frr: add VRF-aware OSPF rendering Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 03/28] sdn: add zone references to OSPF and BGP fabrics Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 04/28] sdn: generate fabric routing configuration in zone VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 05/28] sdn: fix VRF route-map scoping and zone ID validation Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 06/28] tests: fabrics: add tests for fabrics in VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 07/28] sdn: allow static routes in simple zone VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 08/28] pve-rs: fabrics: assign network interfaces to configured VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 09/28] pve-rs: fabrics: make per-fabric status queries VRF-aware Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 10/28] pve-rs: fabrics: include VRF routes in aggregate status Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 11/28] pve-rs: fabrics: expose host interface membership Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 12/28] sdn: expose static routes for simple zone uplinks Gabriel Goller
2026-11-19 19:40 ` [PATCH pve-network v3 13/28] sdn: evpn: add unreachable IPv6 default route to zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 14/28] sdn: add optional VRFs for simple zones Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 15/28] sdn: allow fabrics to use simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 16/28] sdn: require underlay fabrics to use the default VRF Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 17/28] sdn: move full range CIDR formats into a separate module Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 18/28] sdn: simple: support static routes in zone routing tables Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 19/28] sdn: dhcp: only configure DHCP for zones on the local node Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 20/28] sdn: dhcp: run dnsmasq in the zone VRF Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 21/28] sdn: dhcp: fix DNS server option for IPv4 subnets without gateway Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 22/28] sdn: evpn: no exit node null routes for simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH proxmox-widget-toolkit v3 23/28] ui: network: allow selecting a VRF for host interfaces Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 24/28] ui: sdn: add VRF zone selection for fabrics Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 25/28] network: allow setting the VRF of host interfaces Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 26/28] ui: sdn: allow static routes for Simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 27/28] network: generate SDN DHCP config after ifreload Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 28/28] ui: sdn: subnet: allow setting the DHCP DNS server Gabriel Goller
2026-11-20  7:42 ` [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support Thomas Lamprecht
2026-11-20 18:51   ` Gabriel Goller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awCTF7Ly0acZZWoo@luna.proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal