public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support
Date: Fri, 20 Nov 2026 08:42:40 +0100	[thread overview]
Message-ID: <179515721902.2281522.12185275346766103866.b4-ty@b4> (raw)
In-Reply-To: <20261119194116.575520-1-g.goller@proxmox.com>

On Thu, 19 Nov 2026 20:40:46 +0100, Gabriel Goller wrote:
> This series adds VRF support to SDN zones and fabrics.
> 
> A simple zone can now use either the default VRF or a dedicated VRF. The
> simple zone dialog has a checkbox for this and uses the default VRF by
> default. If the checkbox is disabled, the zone creates a dedicated VRF named
> `vrf_<zone-name>`. EVPN zones always create a dedicated VRF. BGP and OSPF
> fabrics can select a zone and run inside its VRF.
> 
> [...]

Applied, thanks!

Tested on a three-node cluster with two VRF zones that use the same
subnet, with SNAT, DHCP and a default route via a VLAN uplink. A setup
like the existing ones still produces the same config, apart from the
new IPv6 unreachable route in EVPN VRFs.

What I changed in your patches:
- Static routes now require a dedicated VRF as without one, the routes
  went into the main routing table of the host, and unchecking the VRF
  moved existing routes there. I went that way as this we can still
  relax easily later without breaking existing configurations. If routes
  in the main table are wanted, a separate SDN object for static routes
  would be the cleaner way.
- The permission check for routes skipped zones with an empty node list,
  which means all nodes. It now checks all nodes in that case.
- Several OSPF fabrics in one VRF could set different options for the
  same kind of redistributed routes, so the FRR config flipped back and
  forth on every apply. Now the first fabric wins. In the default VRF,
  this also means that the other fabrics' redistributions apply now,
  not just the first one's.
- Since your series sets up DHCP after ifreload, one failing interface
  skipped the DHCP config of all zones, and a DHCP error skipped the FRR
  config. Now each step runs even if the other one fails.
- A VRF on an OVS bridge or internal port was rejected, which blocked
  all network changes on a node with such a manual config. Only OVS
  ports and bonds are rejected now, and the UI matches that.
- The dnsmasq override files for the VRF were removed before stopping
  the service, so systemd warned on every apply. They are now removed
  after stopping it.
- I also did some rewording and formatting.

What I added on top:
- ifupdown2 does not enable IPv4 forwarding on VLAN interfaces by
  default, which broke VLAN uplinks for the zone. So I added an explicit
  forwarding option to the network API and UI. This way an admin can
  turn it on without editing the config by hand, and we don't have to
  enable and disable it automatically.
- I reworked the VRF docs to walk through setting up an uplink, and
  documented the new options.

Still open:
- Host interfaces can still point to the VRF of a zone after the zone or
  its VRF is removed. A warning on the node would help.
- A VRF set on a fabric interface makes the whole SDN network config of
  the node fail. A warning might be enough.
- Conflicting OSPF settings between fabrics could be rejected in the API
  instead of the first fabric silently winning.
- If an OSPF or BGP fabric in a VRF uses a WireGuard interface, the
  WireGuard peer routes still go into the main routing table.
- Removing all static routes and unchecking the VRF in one go fails in
  the UI. Doing it in two steps works.

[proxmox-perl-rs]
[08/28] pve-rs: fabrics: assign network interfaces to configured VRFs
       commit: ff405428d1f7276265717dd2808f93b6920c581f
[09/28] pve-rs: fabrics: make per-fabric status queries VRF-aware
       commit: bd2998a7bc577a36b37dd461e581d0ac35936cae
[10/28] pve-rs: fabrics: include VRF routes in aggregate status
       commit: 404f3fd53e0ebe8cb08796f5e0d01b16a78fbb70
[11/28] pve-rs: fabrics: expose host interface membership
       commit: 0bfcd29d6fcb518ce636ed76698fab572ca0e49f
[12/28] sdn: expose static routes for simple zone uplinks
       commit: b43cb5ad263f3c55d6d7b4800c0077bc0c2141e8

[proxmox-ve-rs]
[02/28] frr: add VRF-aware OSPF rendering
       commit: 5301a8b21c54321aa029f6065d2fe3cf99f2aaf3
[03/28] sdn: add zone references to OSPF and BGP fabrics
       commit: 774c88900054d5be352e99f08befb66ad527f6bc
[04/28] sdn: generate fabric routing configuration in zone VRFs
       commit: 147dc3fa661fad46440295fec1f5db99ef4006bf
[05/28] sdn: fix VRF route-map scoping and zone ID validation
       commit: 8370c366a7d8e4c3a3b4ee8c9522b47ab0ce4661
[06/28] tests: fabrics: add tests for fabrics in VRFs
       commit: e12e5e72ce38af9a2e43600e98d5af94c2995d3a
[07/28] sdn: allow static routes in simple zone VRFs
       commit: 67632f4fd7969dd93c04431cd381adb3f074321d

[proxmox-widget-toolkit]
[23/28] ui: network: allow selecting a VRF for host interfaces
       commit: 5375e6472a992537c07b956392c0e47b89ceec9a

[pve-common]
[01/28] interfaces: preserve VRF membership across address family changes
       commit: fb5c8749f9f2fc4a6088637586ab95edd463d813

[pve-manager]
[24/28] ui: sdn: add VRF zone selection for fabrics
       commit: e82f84711d8f8e27f2230e599dd2e783c6bf45b7
[25/28] network: allow setting the VRF of host interfaces
       commit: 0cc7c71e0727d69a53b2b5a1bf9d599ae77749b1
[26/28] ui: sdn: allow static routes for Simple zone VRFs
       commit: 284396bc70b7d81c64fc2aa09e9fbbffbeefd7e0
[27/28] network: generate SDN DHCP config after ifreload
       commit: 04177a199c43ed6a6de1dc9bfa12f1cef5cdaec7
[28/28] ui: sdn: subnet: allow setting the DHCP DNS server
       commit: f603c16d24ec3117d6b9d390dbaa788dc8507a03

[pve-network]
[13/28] sdn: evpn: add unreachable IPv6 default route to zone VRFs
       commit: 33b071063cc1353dfdf45ff33124ab4ecb362d06
[14/28] sdn: add optional VRFs for simple zones
       commit: f0d16fca0e0f45024a08b6ec4cdaf74338028540
[15/28] sdn: allow fabrics to use simple zone VRFs
       commit: 44fe83e54c04ed1e3a57eccca9eab768f705c190
[16/28] sdn: require underlay fabrics to use the default VRF
       commit: 13e7721a15f85f5dc556a9f82a822a66a2d87e98
[17/28] sdn: move full range CIDR formats into a separate module
       commit: 8651469b7696eaec99a6e84770b65ee9cf3112df
[18/28] sdn: simple: support static routes in zone routing tables
       commit: d39115bfd819169aad002027de271ac8e045f4f2
[19/28] sdn: dhcp: only configure DHCP for zones on the local node
       commit: 3419f3f46a4346e3ec78dd27623c9ce02c9ce7e1
[20/28] sdn: dhcp: run dnsmasq in the zone VRF
       commit: 242b26f0b32c58d28ac6da49827f9869d6434cf9
[21/28] sdn: dhcp: fix DNS server option for IPv4 subnets without gateway
       commit: fd3a321fd8a3ea0326da2487d823ccb11ed59eff
[22/28] sdn: evpn: no exit node null routes for simple zone VRFs
       commit: 79ab2a1515fca1705b8ebf53d296e61ed994c9a5




  parent reply	other threads:[~2026-11-20  7:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:40 [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support Gabriel Goller
2026-11-19 19:40 ` [PATCH pve-common v3 01/28] interfaces: preserve VRF membership across address family changes Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 02/28] frr: add VRF-aware OSPF rendering Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 03/28] sdn: add zone references to OSPF and BGP fabrics Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 04/28] sdn: generate fabric routing configuration in zone VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 05/28] sdn: fix VRF route-map scoping and zone ID validation Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 06/28] tests: fabrics: add tests for fabrics in VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 07/28] sdn: allow static routes in simple zone VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 08/28] pve-rs: fabrics: assign network interfaces to configured VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 09/28] pve-rs: fabrics: make per-fabric status queries VRF-aware Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 10/28] pve-rs: fabrics: include VRF routes in aggregate status Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 11/28] pve-rs: fabrics: expose host interface membership Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 12/28] sdn: expose static routes for simple zone uplinks Gabriel Goller
2026-11-19 19:40 ` [PATCH pve-network v3 13/28] sdn: evpn: add unreachable IPv6 default route to zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 14/28] sdn: add optional VRFs for simple zones Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 15/28] sdn: allow fabrics to use simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 16/28] sdn: require underlay fabrics to use the default VRF Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 17/28] sdn: move full range CIDR formats into a separate module Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 18/28] sdn: simple: support static routes in zone routing tables Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 19/28] sdn: dhcp: only configure DHCP for zones on the local node Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 20/28] sdn: dhcp: run dnsmasq in the zone VRF Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 21/28] sdn: dhcp: fix DNS server option for IPv4 subnets without gateway Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 22/28] sdn: evpn: no exit node null routes for simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH proxmox-widget-toolkit v3 23/28] ui: network: allow selecting a VRF for host interfaces Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 24/28] ui: sdn: add VRF zone selection for fabrics Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 25/28] network: allow setting the VRF of host interfaces Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 26/28] ui: sdn: allow static routes for Simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 27/28] network: generate SDN DHCP config after ifreload Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 28/28] ui: sdn: subnet: allow setting the DHCP DNS server Gabriel Goller
2026-11-20  7:42 ` Thomas Lamprecht [this message]
2026-11-20 18:51   ` [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179515721902.2281522.12185275346766103866.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal