Re: [PATCH proxmox-perl-rs 06/15] pve-rs: fabrics: assign network interfaces to configured VRFs

[Gabriel Goller <g.goller@proxmox.com>]

On 21.10.2026 18:14, Stefan Hanreich wrote:
> On 8/21/26 4:04 PM, Gabriel Goller wrote:
> > Add the VRF stanza to generated interface configuration when a fabric
> > has a VRF. Apply it to dummy addresses, protocol interfaces, and BGP
> > unnumbered interfaces so traffic enters the correct routing table.
> > 
> > Fabrics without a VRF keep their existing configuration.
> > 
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> >  pve-rs/src/bindings/sdn/fabrics.rs | 69 +++++++++++++++++++++++-------
> >  1 file changed, 53 insertions(+), 16 deletions(-)
> > 
> > diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs
> > index f96b6b1c656f..98470eeaa397 100644
> > --- a/pve-rs/src/bindings/sdn/fabrics.rs
> > +++ b/pve-rs/src/bindings/sdn/fabrics.rs
> > @@ -582,8 +582,23 @@ pub mod pve_rs_sdn_fabrics {
> >          Ok(interface)
> >      }
> >  
> > +    pub(crate) fn fabric_vrf_name(fabric: &FabricEntry) -> Option<String> {
> > +        let zone = match fabric {
> > +            FabricEntry::Ospf(entry) => entry.fabric_section().properties().zone(),
> > +            FabricEntry::Bgp(entry) => entry.fabric_section().properties().zone(),
> > +            FabricEntry::Openfabric(_) | FabricEntry::WireGuard(_) => None,
> > +        };
> > +
> > +        zone.map(|zone| format!("vrf_{zone}"))
> > +    }
> > +
> 
> nit: maybe better as a method on the fabric config itself? Although I suppose it could be
> argued that it's not the decision of the config how the VRF should be named.

Makes sense, done.

Thanks for the review!

> >      /// Helper function to generate the default `/etc/network/interfaces` config for a given CIDR.
> > -    fn render_interface(name: &str, cidr: Cidr, link_type: Option<&str>) -> Result<String, Error> {
> > +    fn render_interface(
> > +        name: &str,
> > +        cidr: Cidr,
> > +        link_type: Option<&str>,
> > +        vrf: Option<&str>,
> > +    ) -> Result<String, Error> {
> >          let mut interface = String::new();
> >  
> >          writeln!(interface, "auto {name}")?;
> > @@ -595,6 +610,9 @@ pub mod pve_rs_sdn_fabrics {
> >          if let Some(link_type) = link_type {
> >              writeln!(interface, "\tlink-type {link_type}")?;
> >          }
> > +        if let Some(vrf) = vrf {
> > +            writeln!(interface, "\tvrf {vrf}")?;
> > +        }
> >          writeln!(interface, "\tip-forward 1")?;
> >  
> >          Ok(interface)
> > [snip]