[PATCH pve-storage v3 08/19] test: cover efi-firmware volumes in parse_volname and path_to_volume_id

[Christian Ludwig <christian_ludwig@genua.de>]

Check that only names with the safe character class and the '.fd'
extension are recognized as efi-firmware volumes.

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 src/test/parse_volname_test.pm     | 26 ++++++++++++++++++++++++++
 src/test/path_to_volume_id_test.pm | 13 +++++++++++++
 2 files changed, 39 insertions(+)

diff --git a/src/test/parse_volname_test.pm b/src/test/parse_volname_test.pm
index 7e937aa..7c6b4a0 100644
--- a/src/test/parse_volname_test.pm
+++ b/src/test/parse_volname_test.pm
@@ -166,6 +166,14 @@ my $tests = [
         expected => ['import', 'import.ova/disk.raw', undef, undef, undef, undef, 'ova+raw'],
     },
     #
+    # EFI firmware
+    #
+    {
+        description => 'EFI firmware, fd',
+        volname => 'efi-firmware/custom-ovmf-code.fd',
+        expected => ['efi-firmware', 'custom-ovmf-code.fd', undef, undef, undef, undef, 'raw'],
+    },
+    #
     # failed matches
     #
     {
@@ -207,6 +215,24 @@ my $tests = [
         volname => "import/test.foo",
         expected => "unable to parse directory volume name 'import/test.foo'\n",
     },
+    {
+        description => 'Failed match: EFI firmware, wrong extension',
+        volname => 'efi-firmware/custom-ovmf-code.raw',
+        expected =>
+            "unable to parse directory volume name 'efi-firmware/custom-ovmf-code.raw'\n",
+    },
+    {
+        description => 'Failed match: EFI firmware, upper case extension',
+        volname => 'efi-firmware/custom-ovmf-code.FD',
+        expected =>
+            "unable to parse directory volume name 'efi-firmware/custom-ovmf-code.FD'\n",
+    },
+    {
+        description => 'Failed match: EFI firmware, unsafe characters',
+        volname => 'efi-firmware/custom ovmf code.fd',
+        expected =>
+            "unable to parse directory volume name 'efi-firmware/custom ovmf code.fd'\n",
+    },
 ];
 
 # create more test cases for VM disk images matches
diff --git a/src/test/path_to_volume_id_test.pm b/src/test/path_to_volume_id_test.pm
index dfa51e6..10beb5e 100644
--- a/src/test/path_to_volume_id_test.pm
+++ b/src/test/path_to_volume_id_test.pm
@@ -29,6 +29,7 @@ my $scfg = {
                 'iso' => 1,
                 'backup' => 1,
                 'vztmpl' => 1,
+                'efi-firmware' => 1,
             },
         },
     },
@@ -185,6 +186,13 @@ my @tests = (
             'import', 'local:import/import.ovf',
         ],
     },
+    {
+        description => 'EFI firmware, fd',
+        volname => "$storage_dir/efi-firmware/custom-ovmf-code.fd",
+        expected => [
+            'efi-firmware', 'local:efi-firmware/custom-ovmf-code.fd',
+        ],
+    },
 
     # no matches, path or files with failures
     {
@@ -232,6 +240,11 @@ my @tests = (
         volname => "$storage_dir/import/test.foo",
         expected => [''],
     },
+    {
+        description => 'EFI firmware, wrong extension',
+        volname => "$storage_dir/efi-firmware/custom-ovmf-code.raw",
+        expected => [''],
+    },
 );
 
 plan tests => scalar @tests + 1;
-- 
2.34.1