[PATCH qemu-server v3 13/19] test: custom firmware volumes in replication and migration

[Christian Ludwig <christian_ludwig@genua.de>]

Test that custom firmware images are excluded from volume replication,
and that migration is refused for images on a local storage but works
for images on a shared storage.

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 src/test/run_qemu_migrate_tests.pl        | 61 +++++++++++++++++++++++
 src/test/test_get_replicatable_volumes.pl | 10 ++++
 2 files changed, 71 insertions(+)

diff --git a/src/test/run_qemu_migrate_tests.pl b/src/test/run_qemu_migrate_tests.pl
index 05eed1d9..69f2cc1f 100755
--- a/src/test/run_qemu_migrate_tests.pl
+++ b/src/test/run_qemu_migrate_tests.pl
@@ -77,6 +77,7 @@ my $storage_config = {
         "local-dir" => {
             content => {
                 images => 1,
+                'efi-firmware' => 1,
             },
             path => "/some/dir/",
             type => "dir",
@@ -88,6 +89,15 @@ my $storage_config = {
             path => "/some/other/dir/",
             type => "dir",
         },
+        "shared-dir" => {
+            content => {
+                images => 1,
+                'efi-firmware' => 1,
+            },
+            path => "/mnt/pve/shared-dir/",
+            type => "dir",
+            shared => 1,
+        },
         "zfs-alias-1" => {
             content => {
                 images => 1,
@@ -1259,6 +1269,57 @@ my $tests = [
             },
         },
     },
+    {
+        name => '105_local_firmware',
+        target => 'pve1',
+        vmid => 105,
+        vm_status => {
+            running => 0,
+        },
+        config_patch => {
+            bios => 'ovmf,firmware=local-dir:efi-firmware/custom.fd',
+        },
+        expected_calls => {},
+        expect_die => "local custom firmware image - use a shared storage",
+        expected => {
+            source_volids => local_volids_for_vm(105),
+            target_volids => {},
+            vm_config => get_patched_config(
+                105,
+                {
+                    bios => 'ovmf,firmware=local-dir:efi-firmware/custom.fd',
+                },
+            ),
+            vm_status => {
+                running => 0,
+            },
+        },
+    },
+    {
+        name => '105_shared_firmware',
+        target => 'pve1',
+        vmid => 105,
+        vm_status => {
+            running => 0,
+        },
+        config_patch => {
+            bios => 'ovmf,firmware=shared-dir:efi-firmware/custom.fd',
+        },
+        expected_calls => $default_expected_calls_offline,
+        expected => {
+            source_volids => {},
+            target_volids => local_volids_for_vm(105),
+            vm_config => get_patched_config(
+                105,
+                {
+                    bios => 'ovmf,firmware=shared-dir:efi-firmware/custom.fd',
+                },
+            ),
+            vm_status => {
+                running => 0,
+            },
+        },
+    },
     {
         name => '149_running_missing_option_withlocaldisks',
         target => 'pve1',
diff --git a/src/test/test_get_replicatable_volumes.pl b/src/test/test_get_replicatable_volumes.pl
index 6a3d0338..c693ee06 100755
--- a/src/test/test_get_replicatable_volumes.pl
+++ b/src/test/test_get_replicatable_volumes.pl
@@ -22,6 +22,7 @@ my $storecfg = {
                 'backup' => 1,
                 'images' => 1,
                 'rootdir' => 1,
+                'efi-firmware' => 1,
             },
             path => "/var/lib/vz",
         },
@@ -159,5 +160,14 @@ $conf = PVE::QemuServer::parse_vm_config("/qemu-server/$vmid.conf", $rawconf);
 eval { $volumes = PVE::QemuConfig->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 0); };
 is($@, "missing replicate feature on volume 'local:900/vm-900-disk-2.raw'\n", $test_name);
 
+$test_name = "custom firmware is shared, not owned by VM";
+$rawconf = <<__EOD__;
+bios: ovmf,firmware=local:efi-firmware/custom.fd
+__EOD__
+
+$conf = PVE::QemuServer::parse_vm_config("/qemu-server/$vmid.conf", $rawconf);
+$volumes = PVE::QemuConfig->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 0);
+is_deeply($volumes, {}, $test_name);
+
 done_testing();
 exit(0);
-- 
2.34.1