Re: [PATCH pve-qemu-server-rs v2 3/9] pci: legacy: generate q35 chipset devices and hostpcie root ports

[Dominik Csapak <d.csapak@proxmox.com>]

On 10/29/26 2:31 PM, Elias Huhsovitz wrote:
> Comments inline
[snip]
> 
> nit: I understand that setting multifunction=on shouldnt cause any harm
> here, but IMO it should still be encoded in RootPort. e.g.

hmm what would that achieve? we don't have enough information
to decide if it would need it, so the flag would always be `true`.

not sure it makes sense to have a field that does not do anything

> 
> pub struct RootPort {
>      pub addr: PciAddress,
>      /// The bus the root port forms.
>      pub id: Bus,
>      /// The number of the root port, also used as port and chassis number.
>      pub index: u8,
>      pub multifunction: bool,
> }
> 
>>   /// The address a layout assigns to a device.
>>   #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
>>   pub struct AddressAssignment {
> 
> [snip]