public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server v2 6/9] pci: use PVE::RS::PCI bindings for addresses and bus devices
Date: Thu, 29 Oct 2026 14:32:08 +0100	[thread overview]
Message-ID: <DMHCYPSCJ1R8.XJ70M26107I5@proxmox.com> (raw)
In-Reply-To: <20261015081041.743422-7-d.csapak@proxmox.com>

Needs rebase onto the newest version of the hotplug serires (v4) or
master should the hotplug serires get applied.

Otherwise it seems like the functionality remains unchanged.

On Thu Oct 15, 2026 at 10:10 AM CEST, Dominik Csapak wrote:
> Instead of the hardcoded address maps, use the pve-qemu-server-pci crate
> via `PVE::RS::PCI::HardwareConfig` for the addresses of all devices, the
> pci bridges and the root ports of passed through pcie devices.
>
> The object contains the relevant parts of the guest config and the
> machine version (for hotplug the one of the running instance), so we
> construct it once for the commandline or a hotplug operation and pass it
> to the functions that need an address, instead of the arch. The
> functions that also check the machine version still get it separately.
>
> The only functional change is that the root ports of the hostpcie
> devices are now generated together with the bridges, so they move up on
> the commandline. This also fixes hostpcie devices whose root port had no
> function 0 in its slot (e.g. with only hostpci5 configured), which the
> guest did not see. Adapt the hostpci tests accordingly (see [0] for the
> initial bug). Since this is a configuration that is obviously wrong for
> the user (so unlikely to occur in the real world), and the fact that pci
> live migration is still marked experimental, it should be ok to not
> guard that change behind a machine version.
>
> The checks of run_pci_addr_checks.pl are now covered by the tests of the
> rust crate, so remove it.
>
> 0: https://lore.proxmox.com/all/11ce85d1-eb5d-48d1-a4ba-046424613f29@pultar.org/
>
> Fixes: c4e16381 (Add support for up to 16 PCI(e) devices)
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---

[snip]




  reply	other threads:[~2026-10-29 13:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  8:10 [RFC proxmox-perl-rs/qemu-server/qemu-server-rs v2 0/9] pci-handling rewrite (part 1/2/3) Dominik Csapak
2026-10-15  8:10 ` [PATCH pve-qemu-server-rs v2 1/9] add pve-qemu-server-pci crate for guest PCI address generation Dominik Csapak
2026-10-15 12:16   ` Wolfgang Bumiller
2026-10-29 13:31   ` Elias Huhsovitz
2026-10-15  8:10 ` [PATCH pve-qemu-server-rs v2 2/9] pci: legacy: generate pci bridges Dominik Csapak
2026-10-15  8:10 ` [PATCH pve-qemu-server-rs v2 3/9] pci: legacy: generate q35 chipset devices and hostpcie root ports Dominik Csapak
2026-10-29 13:31   ` Elias Huhsovitz
2026-10-15  8:10 ` [PATCH pve-qemu-server-rs v2 4/9] pci: layout: add grouped PCI and PCIe layouts Dominik Csapak
2026-10-29 13:31   ` Elias Huhsovitz
2026-10-15  8:10 ` [PATCH proxmox-perl-rs v2 5/9] pve: add bindings for `pve-qemu-server-pci` crate Dominik Csapak
2026-10-15 11:47   ` Wolfgang Bumiller
2026-10-15  8:10 ` [PATCH qemu-server v2 6/9] pci: use PVE::RS::PCI bindings for addresses and bus devices Dominik Csapak
2026-10-29 13:32   ` Elias Huhsovitz [this message]
2026-10-15  8:10 ` [PATCH qemu-server v2 7/9] tree-wide: use HardwareConfig for the machine version checks Dominik Csapak
2026-10-15  8:10 ` [PATCH qemu-server v2 8/9] cfg2cmd: q35: generate chipset devices with machine version 11.1+pve1 Dominik Csapak
2026-10-15  8:10 ` [PATCH qemu-server v2 9/9] machine: add 'pci-layout' option Dominik Csapak
2026-10-29 15:36 ` [RFC proxmox-perl-rs/qemu-server/qemu-server-rs v2 0/9] pci-handling rewrite (part 1/2/3) Fiona Ebner
2026-10-30 14:13   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMHCYPSCJ1R8.XJ70M26107I5@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal