From: "Daniel Kral" <d.kral@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-ha-manager v2 16/19] manager: log changes to crs settings
Date: Fri, 20 Nov 2026 14:54:16 +0100 [thread overview]
Message-ID: <DN037N60XPWW.1LWILCBSR1U5U@proxmox.com> (raw)
In-Reply-To: <20261112094437.1951271-17-d.rusovac@proxmox.com>
Nice!
Besides the nits, consider as:
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote:
> log the CRS settings when they are first read with non-default values
> and whenever they change, so that it can be traced how the load balancer
> is configured
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>
> Notes:
> changes since v1:
> * use the update_crs_option() helper, which also logs non-default
> values when they are first read
> * keep the log messages for the scheduler mode
> * adjust test logs
> * reword commit
>
> src/PVE/HA/Manager.pm | 49 +++++++++++++++----
> .../log.expect | 2 +
> .../log.expect | 2 +
> .../log.expect | 2 +
> .../log.expect | 3 ++
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 2 +
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 2 +
> .../log.expect | 1 +
> .../test-crs-dynamic-rebalance1/log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 1 +
> .../log.expect | 4 ++
> .../test-crs-static-rebalance1/log.expect | 1 +
> .../test-crs-static-rebalance2/log.expect | 1 +
> 22 files changed, 70 insertions(+), 10 deletions(-)
>
> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
> index a91eec3..7de8781 100644
> --- a/src/PVE/HA/Manager.pm
> +++ b/src/PVE/HA/Manager.pm
> @@ -132,18 +132,47 @@ sub update_crs_settings {
> 'basic',
> );
>
> - $self->{crs}->{rebalance_on_request_start} = !!$crs_cfg->{'ha-rebalance-on-start'};
> - $self->{crs}->{auto_rebalance}->{enable} = !!$crs_cfg->{'ha-auto-rebalance'};
> + my $crs = $self->{crs};
nit: introduce and use the $crs in the previous patch already, so it
can be used to reference $crs->{scheduler}
> + my $auto_rebalance = $crs->{auto_rebalance};
nit: put this either next to $crs as well or right above the
update_crs_option() call for 'ha-auto-rebalance'
> +
> + $self->update_crs_option(
> + 'ha-rebalance-on-start',
> + \$crs->{rebalance_on_request_start},
> + $crs_cfg->{'ha-rebalance-on-start'},
> + 0,
> + );
> + $self->update_crs_option(
> + 'ha-auto-rebalance',
> + \$auto_rebalance->{enable},
> + $crs_cfg->{'ha-auto-rebalance'},
> + 0,
> + );
> # configured as percent for UI/config consistency, scaled to [0, 1] to match the
> # internal imbalance value that the comparison gates against.
> - $self->{crs}->{auto_rebalance}->{threshold} =
> - ($crs_cfg->{'ha-auto-rebalance-threshold'} // 30) / 100.0;
> - $self->{crs}->{auto_rebalance}->{method} = $crs_cfg->{'ha-auto-rebalance-method'}
> - // 'bruteforce';
> - $self->{crs}->{auto_rebalance}->{hold_duration} = $crs_cfg->{'ha-auto-rebalance-hold-duration'}
> - // 3;
> - $self->{crs}->{auto_rebalance}->{margin} =
> - ($crs_cfg->{'ha-auto-rebalance-margin'} // 10) / 100.0;
> + $self->update_crs_option(
> + 'ha-auto-rebalance-threshold',
> + \$auto_rebalance->{threshold},
> + ($crs_cfg->{'ha-auto-rebalance-threshold'} // 30) / 100.0,
> + 0.3,
> + );
> + $self->update_crs_option(
> + 'ha-auto-rebalance-method',
> + \$auto_rebalance->{method},
> + $crs_cfg->{'ha-auto-rebalance-method'},
> + 'bruteforce',
> + );
> + $self->update_crs_option(
> + 'ha-auto-rebalance-hold-duration',
> + \$auto_rebalance->{hold_duration},
> + $crs_cfg->{'ha-auto-rebalance-hold-duration'},
> + 3,
> + );
> + $self->update_crs_option(
> + 'ha-auto-rebalance-margin',
> + \$auto_rebalance->{margin},
> + ($crs_cfg->{'ha-auto-rebalance-margin'} // 10) / 100.0,
> + 0.1,
> + );
>
> return;
> }
next prev parent reply other threads:[~2026-11-20 13:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 9:44 [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox{,-perl-rs} v2 00/19] fix #7993: implement weighted crs load balancing Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 01/19] resource-scheduling: fix typos Dominik Rusovac
2026-11-19 12:27 ` Daniel Kral
2026-11-12 9:44 ` [PATCH proxmox v2 02/19] resource-scheduling: scheduler: refine score_* docs Dominik Rusovac
2026-11-19 12:27 ` Daniel Kral
2026-11-19 12:47 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 03/19] resource-scheduling: scheduler: abstract post-migration stats logic Dominik Rusovac
2026-11-19 12:28 ` Daniel Kral
2026-11-19 12:47 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 04/19] fix #7993: resource-scheduling: node: add weighted node load Dominik Rusovac
2026-11-19 12:28 ` Daniel Kral
2026-11-19 12:50 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 05/19] resource-scheduling: scheduler: make imbalance with candidate public Dominik Rusovac
2026-11-19 12:41 ` Daniel Kral
2026-11-19 12:52 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 06/19] fix #7993: resource-scheduling: scheduler: add weights Dominik Rusovac
2026-11-19 12:40 ` Daniel Kral
2026-11-19 13:52 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 07/19] workspace,resource-scheduling: add proptest as dev-dependency Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 08/19] resource-scheduling: scheduler: add property tests for weights Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox-perl-rs v2 09/19] fix #7993: pve-rs: resource-scheduling: add scheduler options Dominik Rusovac
2026-11-19 12:45 ` Daniel Kral
2026-11-19 13:28 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-cluster v2 10/19] fix #7993: datacenter config: ad ha-{cpu,mem}-weight crs options Dominik Rusovac
2026-11-20 8:43 ` Daniel Kral
2026-11-20 10:05 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-manager v2 11/19] ui: form: crs options: make fine-tuning options advanced Dominik Rusovac
2026-11-20 13:37 ` Daniel Kral
2026-11-20 13:55 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-manager v2 12/19] fix #7993: ui: form: crs options: add weights Dominik Rusovac
2026-11-20 13:35 ` Daniel Kral
2026-11-20 13:49 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 13/19] manager: remove obsolete argument Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 14/19] manager: rename update_crs_scheduler_mod to update_crs_settings Dominik Rusovac
2026-11-20 13:39 ` Daniel Kral
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 15/19] manager: factor out crs option update helper Dominik Rusovac
2026-11-20 13:46 ` Daniel Kral
2026-11-20 14:02 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 16/19] manager: log changes to crs settings Dominik Rusovac
2026-11-20 13:54 ` Daniel Kral [this message]
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 17/19] sim: hardware: allow changing datacenter settings at runtime Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 18/19] fix #7993: manager,usage: use weights for static and dynamic mode Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 19/19] test: add automatic rebalancing test cases with weights Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DN037N60XPWW.1LWILCBSR1U5U@proxmox.com \
--to=d.kral@proxmox.com \
--cc=d.rusovac@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox