public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Rusovac <d.rusovac@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-ha-manager v2 17/19] sim: hardware: allow changing datacenter settings at runtime
Date: Thu, 12 Nov 2026 10:44:35 +0100	[thread overview]
Message-ID: <20261112094437.1951271-18-d.rusovac@proxmox.com> (raw)
In-Reply-To: <20261112094437.1951271-1-d.rusovac@proxmox.com>

This adds commands to change CRS settings or shutdown policy at test
runtime.

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---

Notes:
    changes since v1:
    * reword commit
    * fix accidentally validated empty alternative in the shutdown_policy regex
    * weight options are added with the patch introducing them

 src/PVE/HA/Sim/Hardware.pm | 60 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index e1a9ddd..f3d8301 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -59,6 +59,7 @@ my $default_node_maxmem = 131072 * 1024**2;
 # $testdir/status/service_config              Service configuration
 # $testdir/status/service_status_<node>       Service status
 # $testdir/status/groups                      HA groups configuration
+# $testdir/status/datacenter.cfg              Datacenter wide HA configuration
 
 sub read_lrm_status {
     my ($self, $node) = @_;
@@ -699,6 +700,56 @@ sub write_datacenter_conf {
     PVE::HA::Tools::write_json_to_file($filename, $conf);
 }
 
+my $datacenter_settings = {
+    ha => {
+        shutdown_policy => qr/^(?:conditional|freeze|failover|migrate)$/,
+    },
+    crs => {
+        ha => qr/^(?:basic|static|dynamic)$/,
+        'ha-rebalance-on-start' => qr/^[01]$/,
+        'ha-auto-rebalance' => qr/^[01]$/,
+        'ha-auto-rebalance-threshold' => qr/^\d+(?:\.\d+)?$/,
+        'ha-auto-rebalance-method' => qr/^(?:bruteforce|topsis)$/,
+        'ha-auto-rebalance-hold-duration' => qr/^\d+$/,
+        'ha-auto-rebalance-margin' => qr/^\d+(?:\.\d+)?$/,
+    },
+};
+
+sub update_datacenter_setting {
+    my ($self, $section, $action, $key, $value) = @_;
+
+    my $section_props = $datacenter_settings->{$section}
+        or die "sim_hardware_cmd: unknown datacenter section '$section'\n";
+
+    die "sim_hardware_cmd: missing property for 'datacenter $section $action' command\n"
+        if !defined($key);
+
+    my $verifier = $section_props->{$key}
+        or die "sim_hardware_cmd: unknown datacenter property '$key' in section '$section'\n";
+
+    my $conf = $self->read_datacenter_conf();
+
+    if ($action eq 'set') {
+        die "sim_hardware_cmd: missing value for 'datacenter $section set $key' command\n"
+            if !defined($value);
+        die "sim_hardware_cmd: invalid value '$value' for datacenter property '$section.$key'\n"
+            if $value !~ $verifier;
+
+        $value = $value + 0 if $value =~ m/^\d+(?:\.\d+)?$/;
+
+        $conf->{$section}->{$key} = $value;
+    } elsif ($action eq 'delete') {
+        delete $conf->{$section}->{$key} if $conf->{$section};
+        delete $conf->{$section} if $conf->{$section} && !%{ $conf->{$section} };
+    } else {
+        die "sim_hardware_cmd: unknown datacenter action '$action'\n";
+    }
+
+    $self->write_datacenter_conf($conf);
+
+    return $conf;
+}
+
 sub global_lock {
     my ($self, $code, @param) = @_;
 
@@ -802,6 +853,8 @@ sub get_cfs_state {
 #   service <sid> set-static-stats  [maxcpu <cores>] [maxmem <MiB>]
 #   service <sid> set-dynamic-stats [cpu <cores>] [mem <MiB>]
 #   service <sid> delete
+#   datacenter <ha|crs> set <property> <value>
+#   datacenter <ha|crs> delete <property>
 sub sim_hardware_cmd {
     my ($self, $cmdstr, $logid) = @_;
 
@@ -820,6 +873,8 @@ sub sim_hardware_cmd {
 
         if ($cmd eq 'service') {
             $sid = PVE::HA::Tools::pve_verify_ha_resource_id($objid);
+        } elsif ($cmd eq 'datacenter') {
+            # cluster-wide, neither node nor service specific
         } else {
             $node = $objid;
             $d = $self->{nodes}->{$node}
@@ -1028,6 +1083,11 @@ sub sim_hardware_cmd {
                 die "sim_hardware_cmd: unknown service action '$action' "
                     . "- not implemented\n";
             }
+        } elsif ($cmd eq 'datacenter') {
+            die "sim_hardware_cmd: missing action for 'datacenter $objid' command\n"
+                if !defined($action);
+
+            $self->update_datacenter_setting($objid, $action, @params);
         } else {
             die "sim_hardware_cmd: unknown command '$cmdstr'\n";
         }
-- 
2.47.3





  parent reply	other threads:[~2026-11-12  9:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  9:44 [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox{,-perl-rs} v2 00/19] fix #7993: implement weighted crs load balancing Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 01/19] resource-scheduling: fix typos Dominik Rusovac
2026-11-19 12:27   ` Daniel Kral
2026-11-12  9:44 ` [PATCH proxmox v2 02/19] resource-scheduling: scheduler: refine score_* docs Dominik Rusovac
2026-11-19 12:27   ` Daniel Kral
2026-11-19 12:47     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 03/19] resource-scheduling: scheduler: abstract post-migration stats logic Dominik Rusovac
2026-11-19 12:28   ` Daniel Kral
2026-11-19 12:47     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 04/19] fix #7993: resource-scheduling: node: add weighted node load Dominik Rusovac
2026-11-19 12:28   ` Daniel Kral
2026-11-19 12:50     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 05/19] resource-scheduling: scheduler: make imbalance with candidate public Dominik Rusovac
2026-11-19 12:41   ` Daniel Kral
2026-11-19 12:52     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 06/19] fix #7993: resource-scheduling: scheduler: add weights Dominik Rusovac
2026-11-19 12:40   ` Daniel Kral
2026-11-19 13:52     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 07/19] workspace,resource-scheduling: add proptest as dev-dependency Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 08/19] resource-scheduling: scheduler: add property tests for weights Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox-perl-rs v2 09/19] fix #7993: pve-rs: resource-scheduling: add scheduler options Dominik Rusovac
2026-11-19 12:45   ` Daniel Kral
2026-11-19 13:28     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-cluster v2 10/19] fix #7993: datacenter config: ad ha-{cpu,mem}-weight crs options Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-manager v2 11/19] ui: form: crs options: make fine-tuning options advanced Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-manager v2 12/19] fix #7993: ui: form: crs options: add weights Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 13/19] manager: remove obsolete argument Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 14/19] manager: rename update_crs_scheduler_mod to update_crs_settings Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 15/19] manager: factor out crs option update helper Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 16/19] manager: log changes to crs settings Dominik Rusovac
2026-11-12  9:44 ` Dominik Rusovac [this message]
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 18/19] fix #7993: manager,usage: use weights for static and dynamic mode Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 19/19] test: add automatic rebalancing test cases with weights Dominik Rusovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112094437.1951271-18-d.rusovac@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal