Re: [PATCH qemu-server 1/4] block job: monitor: document that job-complete is not used if source differs from target

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

Comments inline.

On Thu Oct 22, 2026 at 11:38 AM CEST, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/QemuServer/BlockJob.pm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm
> index 493dda33..5757c24f 100644
> --- a/src/PVE/QemuServer/BlockJob.pm
> +++ b/src/PVE/QemuServer/BlockJob.pm
> @@ -82,6 +82,7 @@ sub qemu_blockjobs_cancel {
>  
>  # $completion can be either
>  # 'complete': wait until all jobs are ready, job-complete them (default)
> +#     If the source peer is not the same as the destination VM, uses block-job-cancel instead.

The comments reads like, this a special behaviour of the 'complete',
case. But in this case, isn't the 'complete' & 'cancel' behaviour the
same?

IMO this is just a property of the function. What about something like:

	If the source peer is not the same as the destination VM, no disk
	is switched: 'complete' and 'cancel' both block-job-cancel instead.
    ('skip' and 'auto' are unaffected.)

>  # 'cancel': wait until all jobs are ready, block-job-cancel them
>  # 'skip': wait until all jobs are ready, return with block jobs in ready state
>  # 'auto': wait until all jobs disappear, only use for jobs which complete automatically