public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES qemu-server 0/4] fix #8209: clone disk: do not ignore failure to query size of target
Date: Thu, 22 Oct 2026 11:38:14 +0200	[thread overview]
Message-ID: <20261022093901.52732-1-f.ebner@proxmox.com> (raw)

Since commit 3bae384f ("clone disk: avoid errors after disk was moved
by QEMU"), failure to query the target volume's size after clone is
ignored. It's sensible not to fail hard at this stage, because in case
of live mirror for the same VM with 'complete' completion mode, the
drive was already switched. Also, the error might be a harmless
timeout. Still, as reported in bug #8209, there could be an actual
issue, so log a warning and communicate a failure to the caller, so it
can avoid destructive action.

qemu-server:

Fiona Ebner (4):
  block job: monitor: document that job-complete is not used if source
    differs from target
  fix #8209: clone disk: do not ignore failure to query size of target
  clone disk: abort early when failing to query size of source disk
  clone disk: bump timeout for querying target volume size to 1 minute

 src/PVE/API2/Qemu.pm           | 21 ++++++++++++++-------
 src/PVE/QemuServer.pm          | 18 ++++++++++++++++--
 src/PVE/QemuServer/BlockJob.pm |  1 +
 3 files changed, 31 insertions(+), 9 deletions(-)


Summary over all repositories:
  3 files changed, 31 insertions(+), 9 deletions(-)

-- 
Generated by git-murpp 0.5.0




             reply	other threads:[~2026-10-22  9:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  9:38 Fiona Ebner [this message]
2026-10-22  9:38 ` [PATCH qemu-server 1/4] block job: monitor: document that job-complete is not used if source differs from target Fiona Ebner
2026-10-22  9:38 ` [PATCH qemu-server 2/4] fix #8209: clone disk: do not ignore failure to query size of target Fiona Ebner
2026-10-22 13:25   ` Elias Huhsovitz
2026-10-22  9:38 ` [PATCH qemu-server 3/4] clone disk: abort early when failing to query size of source disk Fiona Ebner
2026-10-22  9:38 ` [PATCH qemu-server 4/4] clone disk: bump timeout for querying target volume size to 1 minute Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022093901.52732-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal