From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 37D1C1FF0AF for ; Thu, 22 Oct 2026 11:39:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 10B8C214FE; Thu, 22 Oct 2026 11:39:24 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server 0/4] fix #8209: clone disk: do not ignore failure to query size of target Date: Thu, 22 Oct 2026 11:38:14 +0200 Message-ID: <20261022093901.52732-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792661959678 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.345 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4EF33EYOQU2BPB4FMOULNKCBFTBF6LDS X-Message-ID-Hash: 4EF33EYOQU2BPB4FMOULNKCBFTBF6LDS X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since commit 3bae384f ("clone disk: avoid errors after disk was moved by QEMU"), failure to query the target volume's size after clone is ignored. It's sensible not to fail hard at this stage, because in case of live mirror for the same VM with 'complete' completion mode, the drive was already switched. Also, the error might be a harmless timeout. Still, as reported in bug #8209, there could be an actual issue, so log a warning and communicate a failure to the caller, so it can avoid destructive action. qemu-server: Fiona Ebner (4): block job: monitor: document that job-complete is not used if source differs from target fix #8209: clone disk: do not ignore failure to query size of target clone disk: abort early when failing to query size of source disk clone disk: bump timeout for querying target volume size to 1 minute src/PVE/API2/Qemu.pm | 21 ++++++++++++++------- src/PVE/QemuServer.pm | 18 ++++++++++++++++-- src/PVE/QemuServer/BlockJob.pm | 1 + 3 files changed, 31 insertions(+), 9 deletions(-) Summary over all repositories: 3 files changed, 31 insertions(+), 9 deletions(-) -- Generated by git-murpp 0.5.0