* [PATCH proxmox] installer-types: align documentation of hdsize for btrfs with lvm & zfs
@ 2026-07-13 9:22 Shannon Sterz
2026-09-24 9:33 ` Christoph Heiss
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Sterz @ 2026-07-13 9:22 UTC (permalink / raw)
To: pve-devel
to avoid confusion. the hdsize is used to determine how much space is
available for partitioning. it is not the size of the btrfs partition
itself. the `LvmOptions` and `ZfsOptions` already specify this
correctly, so align the documentation here to avoid confusion.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
proxmox-installer-types/src/answer.rs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
index 8490d3d6..f07d9f7f 100644
--- a/proxmox-installer-types/src/answer.rs
+++ b/proxmox-installer-types/src/answer.rs
@@ -957,8 +957,7 @@ pub struct LvmOptions {
/// Btrfs-specific filesystem options.
pub struct BtrfsOptions {
#[serde(skip_serializing_if = "Option::is_none")]
- /// Size of the root partition. Optional, will be heuristically determined if
- /// unset.
+ /// Size of the root disk. Optional, will be heuristically determined if unset.
pub hdsize: Option<f64>,
#[serde(skip_serializing_if = "Option::is_none")]
/// RAID level to use.
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH proxmox] installer-types: align documentation of hdsize for btrfs with lvm & zfs
2026-07-13 9:22 [PATCH proxmox] installer-types: align documentation of hdsize for btrfs with lvm & zfs Shannon Sterz
@ 2026-09-24 9:33 ` Christoph Heiss
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Heiss @ 2026-09-24 9:33 UTC (permalink / raw)
To: Shannon Sterz; +Cc: pve-devel
On Mon Jul 13, 2026 at 11:22 AM CEST, Shannon Sterz wrote:
> to avoid confusion. the hdsize is used to determine how much space is
> available for partitioning. it is not the size of the btrfs partition
> itself. the `LvmOptions` and `ZfsOptions` already specify this
> correctly, so align the documentation here to avoid confusion.
Thanks for noticing and fixing it - was probably a simple copy-paste
error by me.
Consider it:
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> proxmox-installer-types/src/answer.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
> index 8490d3d6..f07d9f7f 100644
> --- a/proxmox-installer-types/src/answer.rs
> +++ b/proxmox-installer-types/src/answer.rs
> @@ -957,8 +957,7 @@ pub struct LvmOptions {
> /// Btrfs-specific filesystem options.
> pub struct BtrfsOptions {
> #[serde(skip_serializing_if = "Option::is_none")]
> - /// Size of the root partition. Optional, will be heuristically determined if
> - /// unset.
> + /// Size of the root disk. Optional, will be heuristically determined if unset.
> pub hdsize: Option<f64>,
> #[serde(skip_serializing_if = "Option::is_none")]
> /// RAID level to use.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-24 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 9:22 [PATCH proxmox] installer-types: align documentation of hdsize for btrfs with lvm & zfs Shannon Sterz
2026-09-24 9:33 ` Christoph Heiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox