From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Lukas Sichert" <l.sichert@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager v11 5/6] fix #7339: lvm: add discard-on-remove option to UI
Date: Thu, 30 Jul 2026 16:36:38 +0200 [thread overview]
Message-ID: <DKBZCIYCP2FA.1KZDNV9RFA8NL@proxmox.com> (raw)
In-Reply-To: <20260723135656.102972-6-l.sichert@proxmox.com>
Since my comments from v9 have been addressed and I haven't noticed
anything off here during testing and the changes lgtm:
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
On Thu Jul 23, 2026 at 3:56 PM CEST, Lukas Sichert wrote:
> The LVM storage plugin can now use the `discard` option of the
> `on-volume-remove` property string to discard allocated blocks before
> removing an LV.
[snip]
next prev parent reply other threads:[~2026-07-30 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 13:56 [PATCH docs/manager/storage v11 0/6] fix #7339: lvmthick: add option to free storage for deleted VMs Lukas Sichert
2026-07-23 13:56 ` [PATCH storage v11 1/6] lvm: saferemove: keep LVs where zero-out failed for manual zero-out Lukas Sichert
2026-07-23 13:56 ` [PATCH storage v11 2/6] lvm: saferemove: zero out volumes range by range Lukas Sichert
2026-07-29 15:34 ` Michael Köppl
2026-07-23 13:56 ` [PATCH storage v11 3/6] lvm: saferemove: make throughput an integer property Lukas Sichert
2026-07-23 13:56 ` [PATCH storage v11 4/6] fix #7339: lvm: add discard action for removed volumes Lukas Sichert
2026-07-29 15:12 ` Michael Köppl
2026-07-23 13:56 ` [PATCH manager v11 5/6] fix #7339: lvm: add discard-on-remove option to UI Lukas Sichert
2026-07-30 14:36 ` Michael Köppl [this message]
2026-07-23 13:56 ` [PATCH docs v11 6/6] fix #7339: lvm: document discard option Lukas Sichert
2026-07-30 14:34 ` [PATCH docs/manager/storage v11 0/6] fix #7339: lvmthick: add option to free storage for deleted VMs Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKBZCIYCP2FA.1KZDNV9RFA8NL@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox