From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 494821FF0E2 for ; Thu, 30 Jul 2026 16:36:42 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0CEB721490; Thu, 30 Jul 2026 16:36:42 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 30 Jul 2026 16:36:38 +0200 Message-Id: To: "Lukas Sichert" , Subject: Re: [PATCH manager v11 5/6] fix #7339: lvm: add discard-on-remove option to UI From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.21.0 References: <20260723135656.102972-1-l.sichert@proxmox.com> <20260723135656.102972-6-l.sichert@proxmox.com> In-Reply-To: <20260723135656.102972-6-l.sichert@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785422190282 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.285 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LX6BJ47AI5C3H5SLLTU2GAQHLGGOBIZW X-Message-ID-Hash: LX6BJ47AI5C3H5SLLTU2GAQHLGGOBIZW X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since my comments from v9 have been addressed and I haven't noticed anything off here during testing and the changes lgtm: Reviewed-by: Michael K=C3=B6ppl Tested-by: Michael K=C3=B6ppl On Thu Jul 23, 2026 at 3:56 PM CEST, Lukas Sichert wrote: > The LVM storage plugin can now use the `discard` option of the > `on-volume-remove` property string to discard allocated blocks before > removing an LV. [snip]