From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server] disk clone: warn when fallback is used instead of requested format
Date: Thu, 18 Jun 2026 16:55:25 +0200 [thread overview]
Message-ID: <DJC9G13EHMX2.1CTIJV1XHJITO@proxmox.com> (raw)
In-Reply-To: <20260618125103.1784856-1-m.sandoval@proxmox.com>
On Thu Jun 18, 2026 at 2:50 PM CEST, Maximiliano Sandoval wrote:
> We already print the same warning when importing. See f6039cedf for more
> details.
>
> Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> Tested:
> On a LVM storage with savc enabled:
>
> $ qm disk move 100 scsi0 $storage --format vmdk
>
> which prints:
>
> format 'vmdk' is not supported by the target storage - using 'qcow2' instead
>
> src/PVE/QemuServer.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 55e9f520..80d91a77 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -7936,6 +7936,8 @@ sub clone_disk {
> my $storeid = $storage || $src_storeid;
>
> my $dst_format = resolve_dst_disk_format($storecfg, $storeid, $drive->{file}, $format);
> + warn "format '$format' is not supported by the target storage - using '$dst_format' instead\n"
> + if $format && $format ne $dst_format;
>
> my $name = undef;
> my $size = undef;
work as advertised, so consider this:
Tested-by: Shannon Sterz <s.sterz@proxmox.com>
note that we should probably still align the ui here though and only
allow formats supported by the storage. however, that should not block
this patch.
prev parent reply other threads:[~2026-06-18 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 12:50 [PATCH qemu-server] disk clone: warn when fallback is used instead of requested format Maximiliano Sandoval
2026-06-18 14:55 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJC9G13EHMX2.1CTIJV1XHJITO@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox