From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 211E21FF13F
	for <inbox@lore.proxmox.com>; Thu, 18 Jun 2026 16:56:02 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5D6501B530;
	Thu, 18 Jun 2026 16:56:00 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 18 Jun 2026 16:55:25 +0200
Message-Id: <DJC9G13EHMX2.1CTIJV1XHJITO@proxmox.com>
Subject: Re: [PATCH qemu-server] disk clone: warn when fallback is used
 instead of requested format
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>,
 <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.0
References: <20260618125103.1784856-1-m.sandoval@proxmox.com>
In-Reply-To: <20260618125103.1784856-1-m.sandoval@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1781794522508
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.106 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	URIBL_BLOCKED           0.001 ADMINISTRATOR NOTICE: The query to URIBL was
 blocked.  See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
 for more information. [qemuserver.pm]
Message-ID-Hash: KYVU4GBSODL42SPBOCH77T4RG4DT7BCR
X-Message-ID-Hash: KYVU4GBSODL42SPBOCH77T4RG4DT7BCR
X-MailFrom: s.sterz@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Thu Jun 18, 2026 at 2:50 PM CEST, Maximiliano Sandoval wrote:
> We already print the same warning when importing. See f6039cedf for more
> details.
>
> Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> Tested:
>     On a LVM storage with savc enabled:
>
>     $ qm disk move 100 scsi0 $storage --format vmdk
>
>     which prints:
>
>     format 'vmdk' is not supported by the target storage - using 'qcow2' =
instead
>
>  src/PVE/QemuServer.pm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 55e9f520..80d91a77 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -7936,6 +7936,8 @@ sub clone_disk {
>          my $storeid =3D $storage || $src_storeid;
>
>          my $dst_format =3D resolve_dst_disk_format($storecfg, $storeid, =
$drive->{file}, $format);
> +        warn "format '$format' is not supported by the target storage - =
using '$dst_format' instead\n"
> +            if $format && $format ne $dst_format;
>
>          my $name =3D undef;
>          my $size =3D undef;

work as advertised, so consider this:

Tested-by: Shannon Sterz <s.sterz@proxmox.com>

note that we should probably still align the ui here though and only
allow formats supported by the storage. however, that should not block
this patch.