Re: [PATCH manager v6 2/2] fix #7339: lvmthick: ui: add UI option to free storage

["Michael Köppl" <m.koeppl@proxmox.com>]

On Fri May 22, 2026 at 3:04 PM CEST, Lukas Sichert wrote:

[snip]

>      column1: [
>          {
>              xtype: 'pveBaseStorageSelector',
> @@ -241,5 +274,20 @@ Ext.define('PVE.storage.LVMInputPanel', {
>              uncheckedValue: 0,
>              fieldLabel: gettext('Wipe Removed Volumes'),
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            name: 'on-remove-discard',
> +            uncheckedValue: 0,
> +            cbind: {
> +                checked: '{isCreate}',

I mentioned this on v1 as well, but I'm not sure if enabling this by
default for new LVM storages is a good idea. @Fabian also commented in
v1 "If you don't know what discard means, you should not enable this
option anyway." and the bugzilla issue mentions it as opt-in.

> +            },
> +            fieldLabel: gettext('Discard Removed Volumes'),
> +            autoEl: {
> +                tag: 'div',
> +                'data-qtip': gettext(
> +                    'Enable to issue discard (TRIM) requests for logical volumes before removing them.',
> +                ),
> +            },
> +        },
>      ],
>  });