From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id C445A1FF13B
	for <inbox@lore.proxmox.com>; Mon, 08 Jun 2026 16:06:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 6C8EC1EB5D;
	Mon,  8 Jun 2026 16:06:37 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 08 Jun 2026 16:06:03 +0200
Message-Id: <DJ3Q4S59CAJT.DTPG7NUQ8DZ5@proxmox.com>
Subject: Re: [PATCH manager v6 2/2] fix #7339: lvmthick: ui: add UI option
 to free storage
From: =?utf-8?q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
To: "Lukas Sichert" <l.sichert@proxmox.com>, <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.21.0
References: <20260522130419.94386-1-l.sichert@proxmox.com>
 <20260522130419.94386-3-l.sichert@proxmox.com>
In-Reply-To: <20260522130419.94386-3-l.sichert@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1780927520006
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.091 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: ET2CBWF762GLWINNHBJJINYZ5DKRKC62
X-Message-ID-Hash: ET2CBWF762GLWINNHBJJINYZ5DKRKC62
X-MailFrom: m.koeppl@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Fri May 22, 2026 at 3:04 PM CEST, Lukas Sichert wrote:

[snip]

>      column1: [
>          {
>              xtype: 'pveBaseStorageSelector',
> @@ -241,5 +274,20 @@ Ext.define('PVE.storage.LVMInputPanel', {
>              uncheckedValue: 0,
>              fieldLabel: gettext('Wipe Removed Volumes'),
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            name: 'on-remove-discard',
> +            uncheckedValue: 0,
> +            cbind: {
> +                checked: '{isCreate}',

I mentioned this on v1 as well, but I'm not sure if enabling this by
default for new LVM storages is a good idea. @Fabian also commented in
v1 "If you don't know what discard means, you should not enable this
option anyway." and the bugzilla issue mentions it as opt-in.

> +            },
> +            fieldLabel: gettext('Discard Removed Volumes'),
> +            autoEl: {
> +                tag: 'div',
> +                'data-qtip': gettext(
> +                    'Enable to issue discard (TRIM) requests for logical=
 volumes before removing them.',
> +                ),
> +            },
> +        },
>      ],
>  });