From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH-SERIES storage/qemu-server v3 00/11] fix #7094: external snapshot delete: ensure commit target is large enough
Date: Tue, 26 May 2026 16:36:36 +0200 [thread overview]
Message-ID: <DISON30WEOGT.24CRXO4KP4S9Y@proxmox.com> (raw)
In-Reply-To: <b9cbd19b-9954-49d3-b5de-75a6b86b6b56@proxmox.com>
On 2026-05-26 16:08, Fiona Ebner <f.ebner@proxmox.com> wrote:
> Am 26.05.26 um 3:57 PM schrieb Lukas Sichert:
>> I also tested the live path with the old code using the same general
>> setup. I did not get the same No space left on device failure there;
>> instead the block job was cancelled in my environment, so I could not
>> reproduce the live failure cleanly.
>
> That is the failure for the live case ;) It gets canceled, because there
> is not enough space to commit everything.
I did not want to incluse the 'not' here. I meant that I could reproduce
it cleanly. Sorry for the noise.
>>
>> With the patch installed, the offline case succeeds as expected because
>> the target snapshot LV is resized before commit. I also checked lvmthin
>> for regressions, and normal qm snapshot, qm resize, and qm delsnapshot
>> behavior still works there.
> The live case should work with the patch too, could you test that too?
I also tested live case, which worked as expected.
prev parent reply other threads:[~2026-05-26 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 11:06 [PATCH-SERIES storage/qemu-server v3 00/11] fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 01/11] plugin: document volume_snapshot_info() method Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 02/11] plugin: volume snapshot info: also return virtual size Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 03/11] plugin: document volume_resize() method Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 04/11] plugin/storage: volume resize: add snapname parameter Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 05/11] lvm plugin: snapshot delete: clarify comment about using commit Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 06/11] bump API age and version Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 07/11] partially fix #7094: lvm: snapshot delete: ensure commit target is large enough Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 09/11] plugin: volume snapshot info: correctly return internal snapshot information Fiona Ebner
2026-05-19 11:06 ` [PATCH storage v3 10/11] plugin: volume snapshot info: do not set 'ext' property Fiona Ebner
2026-05-19 11:06 ` [PATCH qemu-server v3 11/11] partially fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner
2026-05-26 13:57 ` [PATCH-SERIES storage/qemu-server v3 00/11] " Lukas Sichert
2026-05-26 14:08 ` Fiona Ebner
2026-05-26 14:36 ` Lukas Sichert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DISON30WEOGT.24CRXO4KP4S9Y@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox