From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E4DAD1FF146 for ; Tue, 26 May 2026 16:36:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9D954186; Tue, 26 May 2026 16:36:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 16:36:36 +0200 Message-Id: Subject: Re: [PATCH-SERIES storage/qemu-server v3 00/11] fix #7094: external snapshot delete: ensure commit target is large enough From: "Lukas Sichert" To: "Fiona Ebner" , References: <20260519110646.25060-1-f.ebner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779806171680 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.414 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3NBEH2JCQHPL5H5JLMEJZ7F2LQRJHPEF X-Message-ID-Hash: 3NBEH2JCQHPL5H5JLMEJZ7F2LQRJHPEF X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-05-26 16:08, Fiona Ebner wrote: > Am 26.05.26 um 3:57 PM schrieb Lukas Sichert: >> I also tested the live path with the old code using the same general >> setup. I did not get the same No space left on device failure there; >> instead the block job was cancelled in my environment, so I could not >> reproduce the live failure cleanly. > > That is the failure for the live case ;) It gets canceled, because there > is not enough space to commit everything. I did not want to incluse the 'not' here. I meant that I could reproduce it cleanly. Sorry for the noise. >>=20 >> With the patch installed, the offline case succeeds as expected because >> the target snapshot LV is resized before commit. I also checked lvmthin >> for regressions, and normal qm snapshot, qm resize, and qm delsnapshot >> behavior still works there. > The live case should work with the patch too, could you test that too? I also tested live case, which worked as expected.