From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager v3] ui: ha: add disarm/re-arm button
Date: Wed, 13 May 2026 10:15:09 +0200 [thread overview]
Message-ID: <DIHEDXX60MFO.22C1HC4EBXPX3@proxmox.com> (raw)
In-Reply-To: <20260416112033.148589-1-d.rusovac@proxmox.com>
Superseded-by: https://lore.proxmox.com/all/20260513081123.1042628-1-d.rusovac@proxmox.com/
On Thu Apr 16, 2026 at 1:20 PM CEST, Dominik Rusovac wrote:
> The button to disarm HA in either of the resource modes ('freeze' or
> 'ignore') is disabled as long as HA is disarmed. Analogously, the button
> to arm HA is disabled as long as HA is not disarmed.
>
> For feedback, after clicking either of the buttons, icon spins as long as
> (dis)arming process has not changed the armed-state of HA.
>
> The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
> and "Arm HA" are complements. There may be more suitable pairs of icons
> though.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> changes since v2:
> * inline setting isDisarmed flag
> * use 'tbar'
> * switch positions of buttons
> * hook into 'hastatuschange' to provide feedback via spinning icon while
> armed-state of HA changes:
> - add 'isDisarmedPendingState' to controller
> - on successful (dis)arm request, store expected 'isDisarmed'-value
> in 'isDisarmedPendingState'
> - match 'isDisarmedPendingState' on 'isDisarmed' in 'hastatuschange'
> and clear 'isDisarmedPendingState'
>
> www/manager6/ha/Status.js | 113 ++++++++++++++++++++++++++++++++++
> www/manager6/ha/StatusView.js | 8 +++
> 2 files changed, 121 insertions(+)
>
[snip]
prev parent reply other threads:[~2026-05-13 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 11:20 [PATCH manager v3] ui: ha: add disarm/re-arm button Dominik Rusovac
2026-05-12 2:43 ` Thomas Lamprecht
2026-05-12 6:58 ` Dominik Rusovac
2026-05-13 8:15 ` Dominik Rusovac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIHEDXX60MFO.22C1HC4EBXPX3@proxmox.com \
--to=d.rusovac@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox